Issue 6842065: juju: do not quite env name in cert

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6842065: juju: do not quite env name in cert

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 4 months ago by rog

Modified:
12 years, 4 months ago

Reviewers:
mp+134932

Visibility:
Public.

Description

juju: do not quite env name in cert Go issue 3791 means that we can only use names which conform to ASN.1's printable strings, which does not include double-quotes. https://code.launchpad.net/~rogpeppe/juju-core/154-juju-fix-cert-name-quoting/+merge/134932 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : juju: do not quite env name in cert #

Created: 12 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -2 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/bootstrap.go	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	juju/bootstrap_test.go	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rog

12 years, 4 months ago (2012-11-19 14:50:38 UTC) #3

*** Submitted:

juju: do not quite env name in cert

Go issue 3791 means that we can only
use names which conform to ASN.1's
printable strings, which does not include
double-quotes.

R=fwereade
CC=
https://codereview.appspot.com/6842065

Expand All Messages | Collapse All Messages