Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(595)

Issue 6828048: Micro Framework for Environment View

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 5 months ago by bcsaller
Modified:
8 years, 5 months ago
Reviewers:
mp+133391
Visibility:
Public.

Description

Micro Framework for Environment View A subclass of Component will container 1 or more modules which implement their own areas of application concern. The pattern is that we can declaratively define event listeners and respond to those across modules. For example A canvas click might fire an application event 'clickedCanvas' which each module can have subscribers for that do things like close menus and remove drag lines, etc. https://code.launchpad.net/~bcsaller/juju-gui/component-framework/+merge/133391 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 44

Patch Set 2 : Micro Framework for Environment View #

Patch Set 3 : Micro Framework for Environment View #

Unified diffs Side-by-side diffs Delta from patch set Stats (+597 lines, -5 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A app/assets/javascripts/d3-components.js View 1 1 chunk +401 lines, -0 lines 0 comments Download
M app/modules.js View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M app/modules-debug.js View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M bin/merge-files View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M test/index.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A test/test_d3_components.js View 1 2 1 chunk +173 lines, -0 lines 0 comments Download

Messages

Total messages: 9
bcsaller
Please take a look.
8 years, 5 months ago (2012-11-08 01:53:16 UTC) #1
thiago
Hi Ben! Thanks for this branch. It seems you had a lot of fun doing ...
8 years, 5 months ago (2012-11-08 13:33:35 UTC) #2
thiago
https://codereview.appspot.com/6828048/diff/1/test/test_d3_components.js File test/test_d3_components.js (right): https://codereview.appspot.com/6828048/diff/1/test/test_d3_components.js#newcode65 test/test_d3_components.js:65: comp.addModule(TestModule); Nothing to assert?
8 years, 5 months ago (2012-11-08 14:13:01 UTC) #3
matthew.scott
This all looks pretty good to me, with a few little minors/clarifications and Thiago's comments. ...
8 years, 5 months ago (2012-11-08 18:49:45 UTC) #4
benjamin.saller
Thank you both for the review feedback. I've made the changes and will propose again ...
8 years, 5 months ago (2012-11-09 13:39:21 UTC) #5
bcsaller
Please take a look.
8 years, 5 months ago (2012-11-09 13:41:47 UTC) #6
matthew.scott
Thanks for the changes! Looks good to me.
8 years, 5 months ago (2012-11-09 18:07:59 UTC) #7
thiago
On 2012/11/09 18:07:59, matthew.scott wrote: > Thanks for the changes! Looks good to me. Thanks, ...
8 years, 5 months ago (2012-11-09 19:30:12 UTC) #8
bcsaller
8 years, 5 months ago (2012-11-13 14:10:27 UTC) #9
*** Submitted:

Micro Framework for Environment View

A subclass of Component will container 1 or more modules 
which implement their own areas of application concern.

The pattern is that we can declaratively define event listeners
and respond to those across modules. For example A canvas click
might fire an application event 'clickedCanvas' which each module
can have subscribers for that do things like close menus and remove
drag lines, etc.

R=thiago, matthew.scott, benjamin.saller
CC=
https://codereview.appspot.com/6828048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b