string socket type

OSL Node needs a string socket to get string parameters (e.g. filepaths).

1) This patch adds the necessary changes in Blender BUT not in Cycles.
For Cycles I think we need to also change:
cycles_xml.cpp and graph.h, graph.cpp

But I prefer to keep the patch clean at first

2) It's not clear to me what is the point of the function:
node_add_input_from_template (on node_socket.c)

So for now I'm passing "" to the string socket. To pass the real value I would need to add a char  property in bNodeSocketTemplate

3) to test it you can use the file (instructions in the file):
http://www.pasteall.org/blend/17320

4) if someone prefer to do the change inloco and commit the patch + changes + cycles change, please go ahead


committed with changes on rev. 51957

[lukas.toenne1, 2012-11-06 10:57:07]

About node_add_input_from_template:
This is used to initialize a socket value from the static C templates. Since we
don't have any string values in these templates so far and don't use them for
existing node types by default, setting it to "" is just fine.

Cycles will need a string value in ShaderInput, next to the "float3 value" used
to store input constants for regular numeric sockets. It won't be stored on the
stack (i wouldn't suggest adding that), so strings cannot be outputs and should
only be used as option buttons on nodes (without a circle to connect). The
default string value can then be passed in OSL nodes to the shader parameter.

https://codereview.appspot.com/6827049/diff/1/source/blender/editors/space_no...
File source/blender/editors/space_node/node_templates.c (right):

https://codereview.appspot.com/6827049/diff/1/source/blender/editors/space_no...
source/blender/editors/space_node/node_templates.c:510: if (sock->link ||
sock->type == SOCK_SHADER || (sock->flag & SOCK_HIDE_VALUE)) {//brb
leftover?

https://codereview.appspot.com/6827049/diff/1/source/blender/nodes/intern/nod...
File source/blender/nodes/intern/node_socket.c (right):

https://codereview.appspot.com/6827049/diff/1/source/blender/nodes/intern/nod...
source/blender/nodes/intern/node_socket.c:161: /****************** SHADER
******************/
should be STRING

https://codereview.appspot.com/6827049/diff/1/source/blender/nodes/intern/nod...
source/blender/nodes/intern/node_socket.c:213: MEM_freeN(sock_string->value);
value is just an array, MEM_freeN is not needed and won't work here. The data is
freed together with default_value below.

[dfelinto, 2012-11-06 18:33:13]

updated, addressed Lukas' points and working in cycles now