Thanks. Sorry about the multiple fixes. I will try to block off enough time to ...
11 years, 4 months ago
(2012-11-08 20:13:55 UTC)
#2
Thanks. Sorry about the multiple fixes. I will try to block off enough time to
do a full audit, but up until now have only had time to fix individual issues as
they come up.
Also pulled. On Thu, Nov 8, 2012 at 12:13 PM, <ahochhaus@samegoal.com> wrote: > Reviewers: gboyer, ...
11 years, 4 months ago
(2012-11-08 20:27:31 UTC)
#3
Also pulled.
On Thu, Nov 8, 2012 at 12:13 PM, <ahochhaus@samegoal.com> wrote:
> Reviewers: gboyer,
>
> Message:
> Thanks. Sorry about the multiple fixes. I will try to block off enough
> time to do a full audit, but up until now have only had time to fix
> individual issues as they come up.
>
>
> Description:
> ContentEditableField always use DOMSubtreeModified on Gecko
>
> Please review this at https://codereview.appspot.com/6826076/
>
> Affected files:
> M closure/goog/editor/field.js
>
>
> Index: closure/goog/editor/field.js
> ===================================================================
> --- closure/goog/editor/field.js (revision 2282)
> +++ closure/goog/editor/field.js (working copy)
> @@ -1013,7 +1013,10 @@
> * @protected
> */
> goog.editor.Field.prototype.setupMutationEventHandlersGecko = function() {
> - if (goog.editor.BrowserFeature.HAS_DOM_SUBTREE_MODIFIED_EVENT) {
> + // Always use DOMSubtreeModified on Gecko when not using an iframe so
> that
> + // DOM mutations outside the Field do not trigger
> handleMutationEventGecko_.
> + if (goog.editor.BrowserFeature.HAS_DOM_SUBTREE_MODIFIED_EVENT ||
> + !this.usesIframe()) {
> this.eventRegister.listen(this.getElement(), 'DOMSubtreeModified',
> this.handleMutationEventGecko_);
> } else {
>
>
From here on out, Garry, you can just check anything you OK into SVN. Nathan ...
11 years, 4 months ago
(2012-11-08 20:27:53 UTC)
#4
From here on out, Garry, you can just check anything you OK into SVN.
Nathan
On Thu, Nov 8, 2012 at 12:27 PM, Nathan Naze <nnaze@google.com> wrote:
> Also pulled.
>
> On Thu, Nov 8, 2012 at 12:13 PM, <ahochhaus@samegoal.com> wrote:
>> Reviewers: gboyer,
>>
>> Message:
>> Thanks. Sorry about the multiple fixes. I will try to block off enough
>> time to do a full audit, but up until now have only had time to fix
>> individual issues as they come up.
>>
>>
>> Description:
>> ContentEditableField always use DOMSubtreeModified on Gecko
>>
>> Please review this at https://codereview.appspot.com/6826076/
>>
>> Affected files:
>> M closure/goog/editor/field.js
>>
>>
>> Index: closure/goog/editor/field.js
>> ===================================================================
>> --- closure/goog/editor/field.js (revision 2282)
>> +++ closure/goog/editor/field.js (working copy)
>> @@ -1013,7 +1013,10 @@
>> * @protected
>> */
>> goog.editor.Field.prototype.setupMutationEventHandlersGecko = function() {
>> - if (goog.editor.BrowserFeature.HAS_DOM_SUBTREE_MODIFIED_EVENT) {
>> + // Always use DOMSubtreeModified on Gecko when not using an iframe so
>> that
>> + // DOM mutations outside the Field do not trigger
>> handleMutationEventGecko_.
>> + if (goog.editor.BrowserFeature.HAS_DOM_SUBTREE_MODIFIED_EVENT ||
>> + !this.usesIframe()) {
>> this.eventRegister.listen(this.getElement(), 'DOMSubtreeModified',
>> this.handleMutationEventGecko_);
>> } else {
>>
>>
Issue 6826076: ContentEditableField always use DOMSubtreeModified on Gecko
Created 11 years, 4 months ago by hochhaus
Modified 11 years, 4 months ago
Reviewers: gboyer
Base URL: http://closure-library.googlecode.com/svn/trunk/
Comments: 1