Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(849)

Issue 6826076: ContentEditableField always use DOMSubtreeModified on Gecko

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by hochhaus
Modified:
1 year, 5 months ago
Reviewers:
gboyer
CC:
nnaze
Base URL:
http://closure-library.googlecode.com/svn/trunk/
Visibility:
Public.

Description

ContentEditableField always use DOMSubtreeModified on Gecko

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M closure/goog/editor/field.js View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4
gboyer
Looks good. Nathan? https://codereview.appspot.com/6826076/diff/1/closure/goog/editor/field.js File closure/goog/editor/field.js (right): https://codereview.appspot.com/6826076/diff/1/closure/goog/editor/field.js#newcode1016 closure/goog/editor/field.js:1016: if (goog.editor.BrowserFeature.HAS_DOM_SUBTREE_MODIFIED_EVENT || Could you add ...
1 year, 5 months ago #1
hochhaus
Thanks. Sorry about the multiple fixes. I will try to block off enough time to ...
1 year, 5 months ago #2
nnaze
Also pulled. On Thu, Nov 8, 2012 at 12:13 PM, <ahochhaus@samegoal.com> wrote: > Reviewers: gboyer, ...
1 year, 5 months ago #3
nnaze
1 year, 5 months ago #4
From here on out, Garry, you can just check anything you OK into SVN.

Nathan

On Thu, Nov 8, 2012 at 12:27 PM, Nathan Naze <nnaze@google.com> wrote:
> Also pulled.
>
> On Thu, Nov 8, 2012 at 12:13 PM,  <ahochhaus@samegoal.com> wrote:
>> Reviewers: gboyer,
>>
>> Message:
>> Thanks. Sorry about the multiple fixes. I will try to block off enough
>> time to do a full audit, but up until now have only had time to fix
>> individual issues as they come up.
>>
>>
>> Description:
>> ContentEditableField always use DOMSubtreeModified on Gecko
>>
>> Please review this at https://codereview.appspot.com/6826076/
>>
>> Affected files:
>>   M     closure/goog/editor/field.js
>>
>>
>> Index: closure/goog/editor/field.js
>> ===================================================================
>> --- closure/goog/editor/field.js        (revision 2282)
>> +++ closure/goog/editor/field.js        (working copy)
>> @@ -1013,7 +1013,10 @@
>>   * @protected
>>   */
>>  goog.editor.Field.prototype.setupMutationEventHandlersGecko = function() {
>> -  if (goog.editor.BrowserFeature.HAS_DOM_SUBTREE_MODIFIED_EVENT) {
>> +  // Always use DOMSubtreeModified on Gecko when not using an iframe so
>> that
>> +  // DOM mutations outside the Field do not trigger
>> handleMutationEventGecko_.
>> +  if (goog.editor.BrowserFeature.HAS_DOM_SUBTREE_MODIFIED_EVENT ||
>> +      !this.usesIframe()) {
>>      this.eventRegister.listen(this.getElement(), 'DOMSubtreeModified',
>>          this.handleMutationEventGecko_);
>>    } else {
>>
>>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5