Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(552)

Issue 6826057: Lightweight assets/improve FF performance

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 5 months ago by matthew.scott
Modified:
8 years, 5 months ago
Reviewers:
mp+132938
Visibility:
Public.

Description

Lightweight assets/improve FF performance Some lighter weight assets for service modules were implemented, via Matt C. Additionally, profiling showed that a lot of slowness for FireFox was caused by FF internals being slow (namely <node>.setAttribute() and <node>.getClientRects()). While we can't fix those being slow, we can reduce the number of times they're used. This is done by modifying attributes on only relevant relation lines when a service is dragged (rather than redrawing or modifying all lines). This results in fewer calls to both of those internals, and speeds up animation in FireFox. https://code.launchpad.net/~makyo/juju-gui/replace-service-module/+merge/132938 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Lightweight assets/improve FF performance #

Total comments: 7

Patch Set 3 : Lightweight assets/improve FF performance #

Unified diffs Side-by-side diffs Delta from patch set Stats (+366 lines, -264 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/assets/svgs/service_health_mask.svg View 3 chunks +196 lines, -128 lines 0 comments Download
M app/assets/svgs/service_module.svg View 2 chunks +124 lines, -131 lines 0 comments Download
M app/views/environment.js View 1 2 5 chunks +44 lines, -5 lines 0 comments Download

Messages

Total messages: 8
matthew.scott
Please take a look.
8 years, 5 months ago (2012-11-05 18:04:29 UTC) #1
gary.poster
+1. Thank you. Gary
8 years, 5 months ago (2012-11-05 18:43:20 UTC) #2
benjamin.saller
The impl looks fine but having tested under FF the new asset doesn't seem to ...
8 years, 5 months ago (2012-11-05 18:57:02 UTC) #3
matthew.scott
Please take a look.
8 years, 5 months ago (2012-11-07 22:41:28 UTC) #4
benjamin.saller
This looks good to me, I had a suggestion to test below, but either way ...
8 years, 5 months ago (2012-11-09 18:38:31 UTC) #5
gary.poster
This makes FF usable for me both on my relatively new desktop and my 3+ ...
8 years, 5 months ago (2012-11-09 21:02:39 UTC) #6
matthew.scott
Thanks https://codereview.appspot.com/6826057/diff/3001/app/modules.js File app/modules.js (right): https://codereview.appspot.com/6826057/diff/3001/app/modules.js#newcode14 app/modules.js:14: 'fullpath': '/juju-ui/assets/javascripts/d3.v2.js' Left over from profiling; back to ...
8 years, 5 months ago (2012-11-09 21:21:32 UTC) #7
matthew.scott
8 years, 5 months ago (2012-11-09 21:27:31 UTC) #8
*** Submitted:

Lightweight assets/improve FF performance

Some lighter weight assets for service modules were implemented, via Matt C. 
Additionally, profiling showed that a lot of slowness for FireFox was caused by
FF internals being slow (namely <node>.setAttribute() and
<node>.getClientRects()).  While we can't fix those being slow, we can reduce
the number of times they're used.  This is done by modifying attributes on only
relevant relation lines when a service is dragged (rather than redrawing or
modifying all lines).  This results in fewer calls to both of those internals,
and speeds up animation in FireFox.

R=gary.poster, benjamin.saller
CC=
https://codereview.appspot.com/6826057
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b