Issue 6823061: version: set development version to 1.9.1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6823061: version: set development version to 1.9.1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
5 years, 2 months ago by dfc

Modified:
5 years, 2 months ago

Reviewers:
mp+132392

Visibility:
Public.

Description

version: set development version to 1.9.1 https://code.launchpad.net/~dave-cheney/juju-core/041-set-development-version-to-1.9.1/+merge/132392 (do not edit description out of merge proposal)

Patch Set 2 : version: set development version to 1.9.1 #

Patch Set 3 : version: set development version to 1.9.1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	version/version.go	View	1	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

niemeyer

LGTM https://codereview.appspot.com/6823061/diff/1/version/version.go File version/version.go (right): https://codereview.appspot.com/6823061/diff/1/version/version.go#newcode17 version/version.go:17: // debian/rules uses this constant for the package ...

5 years, 2 months ago (2012-10-31 17:18:13 UTC) #2

rog

On 2012/10/31 17:14:52, dfc wrote: > Please take a look. LGTM

5 years, 2 months ago (2012-10-31 17:18:14 UTC) #3

dfc

5 years, 2 months ago (2012-10-31 17:38:14 UTC) #5

*** Submitted:

version: set development version to 1.9.1

R=niemeyer, rog
CC=
https://codereview.appspot.com/6823061

Expand All Messages | Collapse All Messages