Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2876)

Issue 6823061: version: set development version to 1.9.1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by dave
Modified:
11 years, 6 months ago
Reviewers:
mp+132392
Visibility:
Public.

Description

version: set development version to 1.9.1 https://code.launchpad.net/~dave-cheney/juju-core/041-set-development-version-to-1.9.1/+merge/132392 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : version: set development version to 1.9.1 #

Patch Set 3 : version: set development version to 1.9.1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M version/version.go View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5
dave_cheney.net
Please take a look.
11 years, 6 months ago (2012-10-31 17:14:52 UTC) #1
niemeyer
LGTM https://codereview.appspot.com/6823061/diff/1/version/version.go File version/version.go (right): https://codereview.appspot.com/6823061/diff/1/version/version.go#newcode17 version/version.go:17: // debian/rules uses this constant for the package ...
11 years, 6 months ago (2012-10-31 17:18:13 UTC) #2
rog
On 2012/10/31 17:14:52, dfc wrote: > Please take a look. LGTM
11 years, 6 months ago (2012-10-31 17:18:14 UTC) #3
dave_cheney.net
Please take a look.
11 years, 6 months ago (2012-10-31 17:23:51 UTC) #4
dave_cheney.net
11 years, 6 months ago (2012-10-31 17:38:14 UTC) #5
*** Submitted:

version: set development version to 1.9.1

R=niemeyer, rog
CC=
https://codereview.appspot.com/6823061
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b