iam: added AccessKeys and DeleteAccessKey

iam: added AccessKeys and DeleteAccessKey

Also included integration tests for CreateAccessKey and these two new
functions.

https://code.launchpad.net/~franciscosouza/goamz/iam-accesskey/+merge/132368

(do not edit description out of merge proposal)

[fss, 2012-10-31 16:26:33]

Please take a look.

[niemeyer, 2012-11-19 14:09:43]

Going in a good direction. The main point to solve is the optional handling of
user names.

https://codereview.appspot.com/6823060/diff/1/iam/iam.go
File iam/iam.go (right):

https://codereview.appspot.com/6823060/diff/1/iam/iam.go#newcode181
iam/iam.go:181: 
Missing comment here.

https://codereview.appspot.com/6823060/diff/1/iam/iam.go#newcode182
iam/iam.go:182: func (iam *IAM) ListAccessKeys(userName string)
(*ListAccessKeyResp, error) {
s/List// would probably work fine. That's a common design pattern on Go code
(e.g. we have ec2.Instances(...) to grab EC2 instances.

AccessKeysResp for the result would also be appropriate.

https://codereview.appspot.com/6823060/diff/1/iam/iam.go#newcode185
iam/iam.go:185: "UserName": userName,
The implementation must handle appropriately lack of a username (it's optional
per docs). Should we convert "" to no-username (not even adding the key) for it
to work?  This should be documented/tested too.

https://codereview.appspot.com/6823060/diff/1/iam/iam.go#newcode194
iam/iam.go:194: // DeleteAccessKey deletes an access key from IAM.
Must also handle/document/test a missing user name.

[fss, 2012-11-20 01:12:03]

Please take a look.

https://codereview.appspot.com/6823060/diff/1/iam/iam.go
File iam/iam.go (right):

https://codereview.appspot.com/6823060/diff/1/iam/iam.go#newcode181
iam/iam.go:181: 
On 2012/11/19 14:09:43, niemeyer wrote:
> Missing comment here.

Done.

https://codereview.appspot.com/6823060/diff/1/iam/iam.go#newcode182
iam/iam.go:182: func (iam *IAM) ListAccessKeys(userName string)
(*ListAccessKeyResp, error) {
On 2012/11/19 14:09:43, niemeyer wrote:
> s/List// would probably work fine. That's a common design pattern on Go code
> (e.g. we have ec2.Instances(...) to grab EC2 instances.
> 
> AccessKeysResp for the result would also be appropriate.

Done.

https://codereview.appspot.com/6823060/diff/1/iam/iam.go#newcode185
iam/iam.go:185: "UserName": userName,
On 2012/11/19 14:09:43, niemeyer wrote:
> The implementation must handle appropriately lack of a username (it's optional
> per docs). Should we convert "" to no-username (not even adding the key) for
it
> to work?  This should be documented/tested too.

Done.

https://codereview.appspot.com/6823060/diff/1/iam/iam.go#newcode194
iam/iam.go:194: // DeleteAccessKey deletes an access key from IAM.
On 2012/11/19 14:09:43, niemeyer wrote:
> Must also handle/document/test a missing user name.

Done.

[fss, 2012-11-27 19:15:29]

Please take a look.

[niemeyer, 2013-02-28 18:04:34]

LGTM

[niemeyer, 2013-02-28 18:05:57]

*** Submitted:

iam: added AccessKeys and DeleteAccessKey

Also included integration tests for CreateAccessKey and these two new
functions.

R=niemeyer
CC=
https://codereview.appspot.com/6823060