Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1534)

Issue 6823057: 'make server' should not always run yuidoc

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by gary.poster
Modified:
11 years, 5 months ago
Reviewers:
teknico, benji, mp+132302
Visibility:
Public.

Description

'make server' should not always run yuidoc I discovered that 'make server' always ran yuidoc. This was because, in part, the automatically generated FILES list included inappropriate files. There is another factor that affects this that I did not identify, but fixing the first problem is sufficient. Fixing the problem specified the JS files more tightly, which revealed a few more lint changes. I did a fly-by in the README. https://code.launchpad.net/~gary/juju-gui/makefile/+merge/132302 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : 'make server' should not always run yuidoc #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -34 lines) Patch
M Makefile View 5 chunks +11 lines, -8 lines 1 comment Download
M README View 1 chunk +4 lines, -0 lines 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/assets/javascripts/svg-layouts.js View 1 chunk +17 lines, -15 lines 0 comments Download
M test-server.js View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 4
gary.poster
Please take a look.
11 years, 5 months ago (2012-10-31 11:25:15 UTC) #1
gary.poster
*** Submitted: 'make server' should not always run yuidoc I discovered that 'make server' always ...
11 years, 5 months ago (2012-10-31 11:31:02 UTC) #2
benji
Looks good. I had one small question. https://codereview.appspot.com/6823057/diff/3001/Makefile File Makefile (right): https://codereview.appspot.com/6823057/diff/3001/Makefile#newcode1 Makefile:1: JSFILES=$(shell bzr ...
11 years, 5 months ago (2012-10-31 12:43:02 UTC) #3
teknico
11 years, 5 months ago (2012-10-31 14:27:28 UTC) #4
Looks good to me. Thanks for the single quotes. :-)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b