Issue 6823050: testing: improve a bit sample charm situation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6823050: testing: improve a bit sample charm situation

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by niemeyer

Modified:
11 years, 6 months ago

Reviewers:
mp+132160, fwereade

Visibility:
Public.

Description

testing: improve a bit sample charm situation Make dummy-v2 trivial and rename it to format. Rename old/new from sample to upgrade, and name their directories properly. https://code.launchpad.net/~niemeyer/juju-core/simplify-sample-charms/+merge/132160 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : testing: improve a bit sample charm situation #

Patch Set 3 : testing: improve a bit sample charm situation #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -56 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charm/meta_test.go	View		1 chunk	+2 lines, -7 lines	0 comments	Download
M	charm/repo_test.go	View	1 2	5 chunks	+6 lines, -6 lines	0 comments	Download
M	juju/testing/conn.go	View		1 chunk	+1 line, -1 line	0 comments	Download
D	testing/repo/series/dummy-v2/build/ignored	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	testing/repo/series/dummy-v2/config.yaml	View		1 chunk	+0 lines, -5 lines	0 comments	Download
D	testing/repo/series/dummy-v2/hooks/install	View		1 chunk	+0 lines, -2 lines	0 comments	Download
D	testing/repo/series/dummy-v2/revision	View		1 chunk	+0 lines, -1 line	0 comments	Download
D	testing/repo/series/dummy-v2/src/hello.c	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	testing/repo/series/format2/metadata.yaml	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	testing/repo/series/upgrade1/metadata.yaml	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	testing/repo/series/upgrade2/metadata.yaml	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	testing/repo/series/wordpress/metadata.yaml	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	worker/uniter/filter_test.go	View		2 chunks	+20 lines, -14 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

On 2012/10/30 16:15:46, niemeyer wrote: > Please take a look. LGTM

11 years, 6 months ago (2012-10-30 16:18:08 UTC) #2

niemeyer

11 years, 6 months ago (2012-11-02 11:40:05 UTC) #3

*** Submitted:

testing: improve a bit sample charm situation

Make dummy-v2 trivial and rename it to format.

Rename old/new from sample to upgrade, and name their
directories properly.

R=fwereade
CC=
https://codereview.appspot.com/6823050

Expand All Messages | Collapse All Messages