Issue 6821058: environs: always clean tools from dummy

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6821058: environs: always clean tools from dummy (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by dave

Modified:
11 years, 6 months ago

Reviewers:
mp+132383

Visibility:
Public.

Description

environs: always clean tools from dummy Various tools_tests assume that they have complete control over the set of tools in an environment. Because dummy always adds a tool matching version.Current, this can conflict with the tests which assume a fixed number of tools in the 1.x, 2.x, and 3.x range. https://code.launchpad.net/~dave-cheney/juju-core/040-release-version-1.9.0/+merge/132383 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs: always clean tools from dummy #

Patch Set 3 : environs: always clean tools from dummy #

Total comments: 1

Patch Set 4 : environs: always clean tools from dummy #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	environs/tools_test.go	View	1 2 3	2 chunks	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rog

LGTM https://codereview.appspot.com/6821058/diff/5001/environs/tools_test.go File environs/tools_test.go (right): https://codereview.appspot.com/6821058/diff/5001/environs/tools_test.go#newcode559 environs/tools_test.go:559: // Remove any tools in the storage to ...

11 years, 6 months ago (2012-10-31 17:04:08 UTC) #5

dave_cheney.net

11 years, 6 months ago (2012-10-31 17:05:50 UTC) #6

*** Submitted:

environs: always clean tools from dummy

Various tools_tests assume that they have complete control over the 
set of tools in an environment. Because dummy always adds a tool matching
version.Current, this can conflict with the tests which assume a fixed
number of tools in the 1.x, 2.x, and 3.x range.

R=niemeyer, rog
CC=
https://codereview.appspot.com/6821058

Expand All Messages | Collapse All Messages