Diff between Tulip and Trollius

Diff between Tulip and Trollius

[haypo_gmail, 2014-02-25 17:00:17]

https://codereview.appspot.com/68210047/diff/1/asyncio/proactor_events.py
File asyncio/proactor_events.py (right):

https://codereview.appspot.com/68210047/diff/1/asyncio/proactor_events.py#new...
asyncio/proactor_events.py:424: self._accept_futures.clear()
I don't remember why I added these lines. It's probably old debug code when I
improve proactor on Windows. These lines should be removed.

https://codereview.appspot.com/68210047/diff/1/asyncio/selector_events.py
File asyncio/selector_events.py (left):

https://codereview.appspot.com/68210047/diff/1/asyncio/selector_events.py#old...
asyncio/selector_events.py:289: err = sock.getsockopt(socket.SOL_SOCKET,
socket.SO_ERROR)
Oh, this line is different in Trollius. It looks like a bug.

https://codereview.appspot.com/68210047/diff/1/asyncio/selectors.py
File asyncio/selectors.py (right):

https://codereview.appspot.com/68210047/diff/1/asyncio/selectors.py#newcode24
asyncio/selectors.py:24: integer_types = (int,)
This should be moved to asyncio.compat.

https://codereview.appspot.com/68210047/diff/1/asyncio/streams.py
File asyncio/streams.py (right):

https://codereview.appspot.com/68210047/diff/1/asyncio/streams.py#newcode270
asyncio/streams.py:270: @tasks.coroutine
Hum, I don't know if this decorator should be added to Tulip, or removed from
Trollius.

https://codereview.appspot.com/68210047/diff/1/asyncio/subprocess.py
File asyncio/subprocess.py (right):

https://codereview.appspot.com/68210047/diff/1/asyncio/subprocess.py#newcode95
asyncio/subprocess.py:95: self.pid =
self._transport.get_extra_info('subprocess').pid
If I remember correctly, transport.get_pid() cannot fail on Tulip because Tulip
works differently because of "yield from", it requires less calls to
loop._run_once().

https://codereview.appspot.com/68210047/diff/1/asyncio/transports.py
File asyncio/transports.py (right):

https://codereview.appspot.com/68210047/diff/1/asyncio/transports.py#newcode99
asyncio/transports.py:99: self.write(b''.join(data))
I'm not sure the the b''.join() is needed here.

https://codereview.appspot.com/68210047/diff/1/asyncio/windows_events.py
File asyncio/windows_events.py (right):

https://codereview.appspot.com/68210047/diff/1/asyncio/windows_events.py#newc...
asyncio/windows_events.py:314: err_cls = get_error_class(err, None)
I don't remember why this is needed.

https://codereview.appspot.com/68210047/diff/1/asyncio/windows_utils.py
File asyncio/windows_utils.py (right):

https://codereview.appspot.com/68210047/diff/1/asyncio/windows_utils.py#newco...
asyncio/windows_utils.py:102: if hasattr(ov, 'GetOverlappedResult'):
This is needed to support Python 3.3 if I remember correctly. I should add a
comment.

https://codereview.appspot.com/68210047/diff/1/examples/crawl.py
File examples/crawl.py (right):

https://codereview.appspot.com/68210047/diff/1/examples/crawl.py#newcode146
examples/crawl.py:146: self.queue[:] = []
It can be written: del self.queue[:].

https://codereview.appspot.com/68210047/diff/1/examples/crawl.py#newcode162
examples/crawl.py:162: h, p = addr[:2]
This change can be ported to Tulip.

[haypo_gmail, 2014-02-26 10:42:30]

https://codereview.appspot.com/68210047/diff/1/asyncio/selector_events.py
File asyncio/selector_events.py (left):

https://codereview.appspot.com/68210047/diff/1/asyncio/selector_events.py#old...
asyncio/selector_events.py:289: err = sock.getsockopt(socket.SOL_SOCKET,
socket.SO_ERROR)
On 2014/02/25 17:00:18, haypo_gmail wrote:
> Oh, this line is different in Trollius. It looks like a bug.

It's fine, I just move some lines into a subfuction _get_socket_error() to be
able to call it in wrap_error().

https://codereview.appspot.com/68210047/diff/1/asyncio/transports.py
File asyncio/transports.py (right):

https://codereview.appspot.com/68210047/diff/1/asyncio/transports.py#newcode99
asyncio/transports.py:99: self.write(b''.join(data))
On 2014/02/25 17:00:18, haypo_gmail wrote:
> I'm not sure the the b''.join() is needed here.

Oh, data is a list of bytes, not a bytes string.