Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(217)

Issue 6820114: code review 6820114: crypto/x509: implement EncryptPEMBlock (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by rog
Modified:
9 years, 9 months ago
Reviewers:
CC:
agl, agl1, golang-dev
Visibility:
Public.

Description

crypto/x509: implement EncryptPEMBlock Arbitrary decisions: order of the arguments and the fact it takes a block-type argument (rather than leaving to user to fill it in later); I'm happy whatever colour we want to paint it. We also change DecryptPEMBlock so that it won't panic when the IV has the wrong size.

Patch Set 1 #

Patch Set 2 : diff -r b661b713984f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b661b713984f https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b661b713984f https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r b661b713984f https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r b661b713984f https://go.googlecode.com/hg/ #

Total comments: 10

Patch Set 7 : diff -r b661b713984f https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r b661b713984f https://go.googlecode.com/hg/ #

Patch Set 9 : diff -r 4e14b1d8a88d https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -29 lines) Patch
M src/pkg/crypto/x509/pem_decrypt.go View 1 2 3 4 5 6 5 chunks +119 lines, -18 lines 0 comments Download
M src/pkg/crypto/x509/pem_decrypt_test.go View 1 2 3 4 5 6 7 chunks +100 lines, -11 lines 0 comments Download

Messages

Total messages: 8
rog
Hello agl@chromium.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 9 months ago (2012-11-07 19:18:36 UTC) #1
rog
Hello agl@chromium.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 9 months ago (2012-11-08 13:41:47 UTC) #2
agl
Moving today. Reviews will be delayed I'm afraid. On Nov 8, 2012 8:41 AM, <rogpeppe@gmail.com> ...
9 years, 9 months ago (2012-11-08 14:04:02 UTC) #3
agl1
https://codereview.appspot.com/6820114/diff/6006/src/pkg/crypto/x509/pem_decrypt.go File src/pkg/crypto/x509/pem_decrypt.go (right): https://codereview.appspot.com/6820114/diff/6006/src/pkg/crypto/x509/pem_decrypt.go#newcode95 src/pkg/crypto/x509/pem_decrypt.go:95: return nil, errors.New("x509: wrong IV size") s/wrong/incorrect/ https://codereview.appspot.com/6820114/diff/6006/src/pkg/crypto/x509/pem_decrypt.go#newcode145 src/pkg/crypto/x509/pem_decrypt.go:145: ...
9 years, 9 months ago (2012-11-09 15:38:14 UTC) #4
rog
Hello agl@chromium.org, agl@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 9 months ago (2012-11-12 10:22:51 UTC) #5
agl1
LGTM
9 years, 9 months ago (2012-11-12 14:00:11 UTC) #6
rog
ha, more comments i forgot to publish https://codereview.appspot.com/6820114/diff/6006/src/pkg/crypto/x509/pem_decrypt.go File src/pkg/crypto/x509/pem_decrypt.go (right): https://codereview.appspot.com/6820114/diff/6006/src/pkg/crypto/x509/pem_decrypt.go#newcode95 src/pkg/crypto/x509/pem_decrypt.go:95: return nil, ...
9 years, 9 months ago (2012-11-12 15:26:04 UTC) #7
rog
9 years, 9 months ago (2012-11-12 15:31:36 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=9ef24096faf2 ***

crypto/x509: implement EncryptPEMBlock

Arbitrary decisions: order of the arguments and the
fact it takes a block-type argument (rather than
leaving to user to fill it in later); I'm happy whatever
colour we want to paint it.

We also change DecryptPEMBlock so that it won't
panic when the IV has the wrong size.

R=agl, agl
CC=golang-dev
http://codereview.appspot.com/6820114
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b