Issue 6820065: juju: consolidate Conn

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6820065: juju: consolidate Conn

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by fwereade

Modified:
11 years, 6 months ago

Reviewers:
mp+132251

Visibility:
Public.

Description

juju: consolidate Conn as discussed live https://code.launchpad.net/~fwereade/juju-core/trivial-consolidate-juju-conn/+merge/132251 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : juju: consolidate Conn #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+355 lines, -372 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/conn.go	View	2 chunks	+136 lines, -0 lines	0 comments	Download
M	juju/conn_test.go	View	7 chunks	+217 lines, -8 lines	0 comments	Download
D	juju/deploy.go	View	1 chunk	+0 lines, -142 lines	0 comments	Download
D	juju/deploy_test.go	View	1 chunk	+0 lines, -222 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

11 years, 6 months ago (2012-10-31 08:51:20 UTC) #3

*** Submitted:

juju: consolidate Conn

as discussed live

R=niemeyer
CC=
https://codereview.appspot.com/6820065

Expand All Messages | Collapse All Messages