Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5221)

Issue 6820056: state: relation keys are now sorted by role

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by fwereade
Modified:
11 years, 6 months ago
Reviewers:
mp+132025
Visibility:
Public.

Description

state: relation keys are now sorted by role fixes lp:1072752 https://code.launchpad.net/~fwereade/juju-core/trivial-sort-relation-keys/+merge/132025 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state: relation keys are now sorted by role #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -13 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/addrelation_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/relation.go View 1 1 chunk +25 lines, -2 lines 0 comments Download
M state/relation_test.go View 1 9 chunks +9 lines, -9 lines 0 comments Download
M state/state_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
fwereade
Please take a look.
11 years, 6 months ago (2012-10-30 09:13:53 UTC) #1
niemeyer
LGTM, thanks.
11 years, 6 months ago (2012-10-30 14:43:13 UTC) #2
fwereade
11 years, 6 months ago (2012-10-30 15:19:05 UTC) #3
*** Submitted:

state: relation keys are now sorted by role

fixes lp:1072752

R=niemeyer
CC=
https://codereview.appspot.com/6820056
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b