Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5)

Issue 6819119: code review 6819119: runtime, runtime/cgo: track memory allocated by non-Go code (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 9 months ago by iant
Modified:
9 years, 9 months ago
Reviewers:
CC:
golang-dev, dfc, dvyukov, minux1
Visibility:
Public.

Description

runtime, runtime/cgo: track memory allocated by non-Go code Otherwise a poorly timed GC can collect the memory before it is returned to the Go program.

Patch Set 1 #

Total comments: 2

Patch Set 2 : diff -r 7d57660045db https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 90e59cec3396 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M src/pkg/runtime/cgo/callbacks.c View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/pkg/runtime/cgocall.c View 1 2 chunks +10 lines, -0 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 3 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 7
iant
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 9 months ago (2012-11-09 07:41:04 UTC) #1
dfc
Very interesting. I wonder if this was a cause of the segfaults we see occasionally ...
9 years, 9 months ago (2012-11-09 07:48:57 UTC) #2
dvyukov
https://codereview.appspot.com/6819119/diff/1/src/pkg/runtime/runtime.h File src/pkg/runtime/runtime.h (right): https://codereview.appspot.com/6819119/diff/1/src/pkg/runtime/runtime.h#newcode226 src/pkg/runtime/runtime.h:226: CgoMal* cgomal; I would prefer moving these 2 fields ...
9 years, 9 months ago (2012-11-09 09:44:09 UTC) #3
minux1
On Fri, Nov 9, 2012 at 3:48 PM, Dave Cheney <dave@cheney.net> wrote: > Very interesting. ...
9 years, 9 months ago (2012-11-09 09:51:32 UTC) #4
iant
https://codereview.appspot.com/6819119/diff/1/src/pkg/runtime/runtime.h File src/pkg/runtime/runtime.h (right): https://codereview.appspot.com/6819119/diff/1/src/pkg/runtime/runtime.h#newcode226 src/pkg/runtime/runtime.h:226: CgoMal* cgomal; On 2012/11/09 09:44:09, dvyukov wrote: > I ...
9 years, 9 months ago (2012-11-09 14:54:04 UTC) #5
dvyukov
On 2012/11/09 14:54:04, iant wrote: > https://codereview.appspot.com/6819119/diff/1/src/pkg/runtime/runtime.h > File src/pkg/runtime/runtime.h (right): > > https://codereview.appspot.com/6819119/diff/1/src/pkg/runtime/runtime.h#newcode226 > ...
9 years, 9 months ago (2012-11-09 15:06:35 UTC) #6
iant
9 years, 9 months ago (2012-11-10 19:19:11 UTC) #7
*** Submitted as http://code.google.com/p/go/source/detail?r=97b8514db41b ***

runtime, runtime/cgo: track memory allocated by non-Go code

Otherwise a poorly timed GC can collect the memory before it
is returned to the Go program.

R=golang-dev, dave, dvyukov, minux.ma
CC=golang-dev
http://codereview.appspot.com/6819119
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b