Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(155)

Issue 6819087: code review 6819087: test/bench/go: new package (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by dfc
Modified:
9 years, 7 months ago
CC:
golang-dev
Visibility:
Public.

Description

test/bench/go: new package As discussed in CL 6813045, this package contains low level micro-benchmarks for gc compiler implementations. Also added additional benchmarks for issues 2230 and 2671.

Patch Set 1 #

Patch Set 2 : diff -r f781c447da6e https://code.google.com/p/go #

Patch Set 3 : diff -r f781c447da6e https://code.google.com/p/go #

Patch Set 4 : diff -r f781c447da6e https://code.google.com/p/go #

Patch Set 5 : diff -r f781c447da6e https://code.google.com/p/go #

Patch Set 6 : diff -r f781c447da6e https://code.google.com/p/go #

Patch Set 7 : diff -r 2b08c2106305 https://code.google.com/p/go #

Patch Set 8 : diff -r 2b08c2106305 https://code.google.com/p/go #

Total comments: 6

Patch Set 9 : diff -r a53601cd4e63 https://code.google.com/p/go #

Patch Set 10 : diff -r a53601cd4e63 https://code.google.com/p/go #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -2 lines) Patch
A test/bench/go/asop_test.go View 1 2 3 4 5 6 7 8 9 1 chunk +73 lines, -0 lines 0 comments Download
M test/bench/go/divmul_test.go View 1 2 3 4 5 6 7 8 9 4 chunks +116 lines, -2 lines 2 comments Download
A test/bench/go/doc.go View 1 2 3 4 5 6 7 8 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 19
dfc
Hello minux.ma@gmail.com, r@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 8 months ago (2012-11-05 01:16:18 UTC) #1
r
I thought we decided on test/bench/go -rob
9 years, 8 months ago (2012-11-05 06:59:44 UTC) #2
dfc
Yes, but package go is a syntax error. The workaround is to drop doc.go and ...
9 years, 8 months ago (2012-11-05 07:02:44 UTC) #3
rsc
Please make the directory test/bench/go. The package can be 'package bench'. Thanks.
9 years, 8 months ago (2012-11-06 18:42:37 UTC) #4
dfc
Hello minux.ma@gmail.com, r@golang.org, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 8 months ago (2012-11-07 00:14:16 UTC) #5
rsc
LGTM https://codereview.appspot.com/6819087/diff/10001/test/bench/go/asop_test.go File test/bench/go/asop_test.go (right): https://codereview.appspot.com/6819087/diff/10001/test/bench/go/asop_test.go#newcode12 test/bench/go/asop_test.go:12: } I would suggest add a global var ...
9 years, 8 months ago (2012-11-07 14:25:40 UTC) #6
r
https://codereview.appspot.com/6819087/diff/10001/test/bench/go/asop_test.go File test/bench/go/asop_test.go (right): https://codereview.appspot.com/6819087/diff/10001/test/bench/go/asop_test.go#newcode9 test/bench/go/asop_test.go:9: func BenchmarkLSL(b *testing.B) { it seems if you have ...
9 years, 8 months ago (2012-11-07 16:12:40 UTC) #7
dfc
Thank you for your comments. I know these benchmarks must appear trivial, but they expose ...
9 years, 8 months ago (2012-11-08 01:20:33 UTC) #8
dfc
On 2012/11/08 01:20:33, dfc wrote: > Thank you for your comments. I know these benchmarks ...
9 years, 7 months ago (2012-11-09 22:35:37 UTC) #9
r
I think they do belong. -rob
9 years, 7 months ago (2012-11-09 22:40:37 UTC) #10
r
https://codereview.appspot.com/6819087/diff/5005/test/bench/go/divmul_test.go File test/bench/go/divmul_test.go (right): https://codereview.appspot.com/6819087/diff/5005/test/bench/go/divmul_test.go#newcode158 test/bench/go/divmul_test.go:158: func BenchmarkMul4(b *testing.B) { let's be pedantic and name ...
9 years, 7 months ago (2012-11-09 22:41:55 UTC) #11
dfc
Yes, I also realised I need to add benchmarks for int8,uint8,int16,uint16,etc. Thank you for your ...
9 years, 7 months ago (2012-11-09 22:50:22 UTC) #12
r
It might make sense to generate the benchmarks rather than type them all in.
9 years, 7 months ago (2012-11-09 22:57:39 UTC) #13
mtj1
I use M4 for things like this... On Fri, Nov 9, 2012 at 2:57 PM, ...
9 years, 7 months ago (2012-11-09 23:00:19 UTC) #14
r
I use Go for things like this. -rob
9 years, 7 months ago (2012-11-09 23:19:15 UTC) #15
mtj1
no doubt. On Fri, Nov 9, 2012 at 3:19 PM, Rob Pike <r@golang.org> wrote: > ...
9 years, 7 months ago (2012-11-09 23:23:45 UTC) #16
bradfitz
https://codereview.appspot.com/6819087/diff/5005/test/bench/go/divmul_test.go File test/bench/go/divmul_test.go (right): https://codereview.appspot.com/6819087/diff/5005/test/bench/go/divmul_test.go#newcode176 test/bench/go/divmul_test.go:176: func BenchmarkMagicMul10(b *testing.B) { if v == 5, the ...
9 years, 7 months ago (2012-11-11 23:48:02 UTC) #17
remyoudompheng
Dave, are you going to finalize these microbenchmarks? I don't understand why the CL is ...
9 years, 7 months ago (2012-11-14 22:31:12 UTC) #18
dfc
9 years, 7 months ago (2012-11-14 22:34:07 UTC) #19
As I've been working on this CL I've learnt that the task is larger then I
originally thought so I'm going to try again with a fresh proposal, soon, I
promise. 

On 15/11/2012, at 9:31, remyoudompheng@gmail.com wrote:

> Dave, are you going to finalize these microbenchmarks? I don't
> understand why the CL is closed.
> 
> http://codereview.appspot.com/6819087/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b