Issue 6819056: s3: TODO doesn't seem necessary

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6819056: s3: TODO doesn't seem necessary

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by niemeyer

Modified:
11 years, 3 months ago

Reviewers:
dave, mp+132250, fwereade

Visibility:
Public.

Description

s3: TODO doesn't seem necessary As discussed with Dave. https://code.launchpad.net/~niemeyer/goamz/trivial-comment-drop/+merge/132250 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : s3: TODO doesn't seem necessary #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	s3/s3i_test.go	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dave_cheney.net

On 2012/10/31 08:27:51, niemeyer wrote: > Please take a look. LGTM.

11 years, 6 months ago (2012-10-31 08:34:53 UTC) #2

niemeyer

11 years, 3 months ago (2013-01-28 13:30:31 UTC) #4

*** Submitted:

s3: TODO doesn't seem necessary

As discussed with Dave.

R=
CC=
https://codereview.appspot.com/6819056

Expand All Messages | Collapse All Messages