Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(263)

Issue 6818110: Triangulate modifier

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by psy-fi
Modified:
9 years, 6 months ago
Reviewers:
brechtvl
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

Triangulate modifier. The rationale for its usefulness is twofold: 1) It allows artists to non-destructively see the triangulation of their models 2) It allows to have a consistent base for bump mapping, especially with Morten Mikkelsen's method we use for blender. Also added the ability for CDDM_create_edges to propagate MEdge flags.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -3 lines) Patch
release/scripts/startup/bl_ui/properties_data_modifier.py View 1 chunk +3 lines, -0 lines 0 comments Download
source/blender/blenkernel/intern/cdderivedmesh.c View 3 chunks +10 lines, -3 lines 0 comments Download
source/blender/editors/space_outliner/outliner_draw.c View 1 chunk +2 lines, -0 lines 0 comments Download
source/blender/makesdna/DNA_modifier_types.h View 2 chunks +9 lines, -0 lines 0 comments Download
source/blender/makesrna/intern/rna_modifier.c View 4 chunks +21 lines, -0 lines 1 comment Download
source/blender/modifiers/CMakeLists.txt View 1 chunk +1 line, -0 lines 1 comment Download
source/blender/modifiers/MOD_modifiertypes.h View 1 chunk +1 line, -0 lines 0 comments Download
source/blender/modifiers/intern/MOD_triangulate.c View 1 chunk +147 lines, -0 lines 1 comment Download
source/blender/modifiers/intern/MOD_util.c View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
psy-fi
9 years, 6 months ago (2012-11-09 14:45:20 UTC) #1
brechtvl
9 years, 6 months ago (2012-11-19 20:11:16 UTC) #2
LGTM besides the minor issues mentioned.

There may be better solutions to keep triangulation consistent by default, but
this is also useful outside of that, so I don't think it will hurt having this.

https://codereview.appspot.com/6818110/diff/1/source/blender/makesrna/intern/...
File source/blender/makesrna/intern/rna_modifier.c (right):

https://codereview.appspot.com/6818110/diff/1/source/blender/makesrna/intern/...
source/blender/makesrna/intern/rna_modifier.c:3370: +	prop =
RNA_def_property(srna, "beauty", PROP_BOOLEAN, PROP_NONE);
Booleans should have the use_ prefix in property names.

https://codereview.appspot.com/6818110/diff/1/source/blender/modifiers/CMakeL...
File source/blender/modifiers/CMakeLists.txt (right):

https://codereview.appspot.com/6818110/diff/1/source/blender/modifiers/CMakeL...
source/blender/modifiers/CMakeLists.txt:97: intern/MOD_triangulate.c
This looks like it is using spaces rather than a tab.

https://codereview.appspot.com/6818110/diff/1/source/blender/modifiers/intern...
File source/blender/modifiers/intern/MOD_triangulate.c (right):

https://codereview.appspot.com/6818110/diff/1/source/blender/modifiers/intern...
source/blender/modifiers/intern/MOD_triangulate.c:99: if(!(result =
triangulate(dm, tmd->beauty))) {
Pedantic: code style say "if (" rather than "if(".
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b