Issue 6818053: store: prefer c.Assert to panic

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6818053: store: prefer c.Assert to panic (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by dave

Modified:
11 years, 6 months ago

Reviewers:
mp+132078

Visibility:
Public.

Description

store: prefer c.Assert to panic Updates #1073125. Replace a bunch of panics with Asserts to make the underlying issue more obvious. https://code.launchpad.net/~dave-cheney/juju-core/store-failure-I/+merge/132078 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : store: prefer c.Assert to panic #

Patch Set 3 : store: prefer c.Assert to panic #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -10 lines)			Patch
	A	[revision details]	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	store/mgo_test.go	View		2 chunks	+6 lines, -10 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rog

On 2012/10/30 11:49:01, dfc wrote: > Please take a look. LGTM

11 years, 6 months ago (2012-10-30 11:53:03 UTC) #3

dave_cheney.net

11 years, 6 months ago (2012-10-30 11:53:50 UTC) #5

*** Submitted:

store: prefer c.Assert to panic

Updates #1073125.

Replace a bunch of panics with Asserts to make the underlying issue more
obvious.

R=rog
CC=
https://codereview.appspot.com/6818053

Expand All Messages | Collapse All Messages