Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(236)

Issue 6817116: Added SES tests for two Chrome bugs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by metaweta
Modified:
1 year, 4 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Added SES tests for two Chrome bugs:
1) If you make an array's length read-only and then add an element to
the array, the length gets changed.
2) In non-strict code, this fails:
var x = (function a() {
  function a() {} // Should mask outer defn
  eval(""); // Just has to be here; removing it changes the behavior
  return a;
});
assert(x() !== x);

The first bug is a violation with no known exploit; the second is safe
because we're in strict mode.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -3 lines) Patch
M src/com/google/caja/ses/repairES5.js View 7 chunks +54 lines, -3 lines 0 comments Download

Messages

Total messages: 2
metaweta
1 year, 5 months ago #1
felix8a
1 year, 5 months ago #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1274:9b9295c7fd64