Issue 6816065: Fixes issue 158736: use the pseudo-patience sequence matcher only for full lines.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6816065: Fixes issue 158736: use the pseudo-patience sequence matcher only for full lines. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by macourteau2

Modified:
13 years, 7 months ago

Reviewers:
M-A

CC:
codereview-discuss_googlegroups.com

Visibility:
Public.

Fixes issue 158736: use the pseudo-patience sequence matcher only for full lines. BUG=158736

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	codereview/engine.py	View		2 chunks	+1 line, -2 lines	0 comments	Download
	M	codereview/intra_region_diff.py	View		2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 5

macourteau2

Yes, it's still being used in patching.py, where the matching of diff lines is made. ...

13 years, 7 months ago (2012-10-31 15:59:47 UTC) #3

M-A

13 years, 7 months ago (2012-11-02 19:51:27 UTC) #5

Committed as
https://code.google.com/p/rietveld/source/detail?r=cf2ff50d3c5555f0b31160eefd...

Please close.