Issue 6815059: code review 6815059: runtime: move Itab to runtime.h

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6815059: code review 6815059: runtime: move Itab to runtime.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by atom

Modified:
12 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

runtime: move Itab to runtime.h The 'type' field of Itab will be used by the garbage collector.

Patch Set 1 #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -14 lines)			Patch
	M	src/pkg/runtime/iface.c	View		1 chunk	+0 lines, -13 lines	0 comments	Download
	M	src/pkg/runtime/runtime.h	View		3 chunks	+13 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

atom

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 5 months ago (2012-10-31 15:28:07 UTC) #1

rsc

Why? Please include information about reasons for changes in the CL descriptions so that we ...

12 years, 5 months ago (2012-10-31 15:33:06 UTC) #2

atom

On 2012/10/31 15:33:06, rsc wrote: > Why? > > Please include information about reasons for ...

12 years, 5 months ago (2012-10-31 15:41:57 UTC) #3

rsc

12 years, 5 months ago (2012-11-01 17:13:25 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=3da84d211bb9 ***

runtime: move Itab to runtime.h

The 'type' field of Itab will be used by the garbage collector.

R=rsc
CC=golang-dev
http://codereview.appspot.com/6815059

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages