Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3)

Issue 68150046: code review 68150046: spec: clarify default "true" condition/tag in for/switc... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by gri
Modified:
11 years, 2 months ago
Reviewers:
r, gobot, iant
CC:
r, iant, rsc, ken2, golang-codereviews
Visibility:
Public.

Description

spec: clarify default "true" condition/tag in for/switch statements An absent condition/tag in for and switch statements is equivalent to the predeclared constant true; not simply the expression true (which might lead to a locally defined true). Not a language change. Fixes issue 7404.

Patch Set 1 #

Patch Set 2 : diff -r e56c848d6c75 https://code.google.com/p/go #

Patch Set 3 : diff -r e56c848d6c75 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r 86be37c8d562 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 86be37c8d562 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M doc/go_spec.html View 1 2 3 4 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 7
gri
Hello r@golang.org, iant@golang.org, rsc@golang.org, ken@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to ...
11 years, 2 months ago (2014-02-25 03:32:41 UTC) #1
iant
LGTM
11 years, 2 months ago (2014-02-25 03:59:37 UTC) #2
r
https://codereview.appspot.com/68150046/diff/40001/doc/go_spec.html File doc/go_spec.html (right): https://codereview.appspot.com/68150046/diff/40001/doc/go_spec.html#newcode4463 doc/go_spec.html:4463: <code>true</code>. I would just say boolean value true. Why ...
11 years, 2 months ago (2014-02-25 07:11:07 UTC) #3
gri
PTAL On Mon, Feb 24, 2014 at 11:11 PM, <r@golang.org> wrote: > > https://codereview.appspot.com/68150046/diff/40001/doc/go_spec.html > ...
11 years, 2 months ago (2014-02-25 17:00:35 UTC) #4
r
LGTM
11 years, 2 months ago (2014-02-25 17:12:12 UTC) #5
gri
*** Submitted as https://code.google.com/p/go/source/detail?r=838ade034dc6 *** spec: clarify default "true" condition/tag in for/switch statements An absent ...
11 years, 2 months ago (2014-02-25 17:13:41 UTC) #6
gobot
11 years, 2 months ago (2014-02-25 17:27:29 UTC) #7
Message was sent while issue was closed.
This CL appears to have broken the windows-386-ec2 builder.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b