Issue 6814125: Fix 1px too wide svg issue

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6814125: Fix 1px too wide svg issue

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by matthew.scott

Modified:
12 years, 5 months ago

Reviewers:
mp+133989

Visibility:
Public.

Description

Fix 1px too wide svg issue Due to sizes being set with percentages, widths are computed as decimals, but are reported as integers in DOM attributes (Computed width: 1331.949951171875, reported width: 1332) resulting in rounding errors. YUI's getComputedStyle() returns the decimal width, allowing us to round. https://code.launchpad.net/~makyo/juju-gui/svg-width-bug-1076413/+merge/133989 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix 1px too wide svg issue #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	app/views/utils.js	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

matthew.scott

12 years, 5 months ago (2012-11-13 15:35:21 UTC) #4

*** Submitted:

Fix 1px too wide svg issue

Due to sizes being set with percentages, widths are computed as decimals, but
are reported as integers in DOM attributes (Computed width: 1331.949951171875,
reported width: 1332) resulting in rounding errors.  YUI's getComputedStyle()
returns the decimal width, allowing us to round.

R=francesco.banconi, bac
CC=
https://codereview.appspot.com/6814125

Expand All Messages | Collapse All Messages