Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(951)

Issue 6814092: Fix Makefile error wrt spritegen

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by bac
Modified:
11 years, 6 months ago
Reviewers:
mp+133063
Visibility:
Public.

Description

Fix Makefile error wrt spritegen If app/assets/sprite exists then regenerating sprites failed since the logic assumed the directory would not be there. Remove the directory before copying the contents of the newly generated sprite data. Self-reviewed. https://code.launchpad.net/~bac/juju-gui/spritegen-trivial/+merge/133063 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix Makefile error wrt spritegen #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Makefile View 1 chunk +2 lines, -1 line 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2
bac
Please take a look.
11 years, 6 months ago (2012-11-06 13:19:11 UTC) #1
bac
11 years, 6 months ago (2012-11-06 13:21:49 UTC) #2
*** Submitted:

Fix Makefile error wrt spritegen

If app/assets/sprite exists then regenerating sprites failed since the
logic assumed the directory would not be there.  Remove the directory
before copying the contents of the newly generated sprite data.

Self-reviewed.

R=
CC=
https://codereview.appspot.com/6814092
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b