Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(78)

Issue 6814091: Default to order search results by '-modified' (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Isaac
Modified:
1 year, 5 months ago
Reviewers:
M-A Ruel, Roger Tawa, M-A
CC:
codereview-discuss_googlegroups.com
Visibility:
Public.

Description

Default to order search results by '-modified'

This will make searches better.  Most of the time you want recent results, not
oldest ones.

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Updated comment and sort order when multiple fields are specified #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M codereview/views.py View 1 2 1 chunk +18 lines, -18 lines 0 comments Download

Messages

Total messages: 13
Isaac
Hi Roger, do you have time for a quick rietveld review? Cheers! -Isaac
1 year, 5 months ago #1
Isaac
+M-A
1 year, 5 months ago #2
M-A
https://codereview.appspot.com/6814091/diff/1/codereview/views.py File codereview/views.py (right): https://codereview.appspot.com/6814091/diff/1/codereview/views.py#newcode508 codereview/views.py:508: [('-modified', '(default)')])) The problem is that is requires a ...
1 year, 5 months ago #3
M-A
+ ML
1 year, 5 months ago #4
Isaac
Can I just add a catch all clause on line 3662 that sets sorted_by to ...
1 year, 5 months ago #5
M-A
On 2012/11/06 21:45:45, Isaac wrote: > Can I just add a catch all clause on ...
1 year, 5 months ago #6
Isaac
PTAL
1 year, 5 months ago #7
M-A Ruel
lgtm
1 year, 5 months ago #8
Roger Tawa
https://codereview.appspot.com/6814091/diff/5002/codereview/views.py File codereview/views.py (right): https://codereview.appspot.com/6814091/diff/5002/codereview/views.py#newcode3645 codereview/views.py:3645: # Default sort by ascending key to save on ...
1 year, 5 months ago #9
Isaac
https://codereview.appspot.com/6814091/diff/5002/codereview/views.py File codereview/views.py (right): https://codereview.appspot.com/6814091/diff/5002/codereview/views.py#newcode3645 codereview/views.py:3645: # Default sort by ascending key to save on ...
1 year, 5 months ago #10
Roger Tawa
Lgtm On Nov 6, 2012 8:40 PM, <ilevy@chromium.org> wrote: > > https://codereview.appspot.**com/6814091/diff/5002/**codereview/views.py<https://codereview.appspot.com/6814091/diff/5002/codereview/views.py> > File codereview/views.py ...
1 year, 5 months ago #11
Roger Tawa
Lgtm On Nov 6, 2012 8:40 PM, <ilevy@chromium.org> wrote: > > https://codereview.appspot.**com/6814091/diff/5002/**codereview/views.py<https://codereview.appspot.com/6814091/diff/5002/codereview/views.py> > File codereview/views.py ...
1 year, 5 months ago #12
M-A
1 year, 5 months ago #13
Committed, you can close the issue.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5