cmd/juju: implement resolved

cmd/juju: implement resolved



https://code.launchpad.net/~fwereade/juju-core/cmd-juju-resolved/+merge/132048

(do not edit description out of merge proposal)

[fwereade, 2012-10-30 10:37:09]

Please take a look.

[jameinel, 2012-10-30 11:33:44]

Looks good to me.

Some slight reservations that the table-based test is updating state that is
dependent for follow up tests (we set the state of dummy/3 and then expect the
next case to fail because the state has already been reset.)

But it tests the edges, and the model fits with other tests that I've seen.

[niemeyer, 2012-10-30 14:48:09]

Seems reasonable, but a minor:

https://codereview.appspot.com/6814055/diff/1/cmd/juju/resolved.go
File cmd/juju/resolved.go (right):

https://codereview.appspot.com/6814055/diff/1/cmd/juju/resolved.go#newcode47
cmd/juju/resolved.go:47: defer conn.Close()
I think we should put the stuff below in a method in juju.Conn, to go into the
direction we discussed in the mailing list.

[fwereade, 2012-10-31 10:36:42]

Please take a look.

[jameinel, 2012-10-31 10:45:05]

LGTM

[niemeyer, 2012-10-31 10:48:08]

LGTM, assuming the following trivial:

https://codereview.appspot.com/6814055/diff/6001/juju/conn.go
File juju/conn.go (right):

https://codereview.appspot.com/6814055/diff/6001/juju/conn.go#newcode238
juju/conn.go:238: func (conn *Conn) ResolveUnit(unit *state.Unit, retryHooks
bool) error {
s/ResolveUnit/Resolved/, plus:

// Resolved marks the unit as having had any previous state transition
// problems resolved, and informs the unit that it may attempt to
// reestablish normal workflow. The retryHooks parameter informs
// whether to attempt to reexecute previous failed hooks or to continue
// as if they had succeeded before.

[fwereade, 2012-10-31 11:10:06]

*** Submitted:

cmd/juju: implement resolved

R=john.meinel, niemeyer
CC=
https://codereview.appspot.com/6814055