Issue 68140043: SSL Support for RabbitMQ

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 68140043: SSL Support for RabbitMQ

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by hazmat

Modified:
10 years, 1 month ago

Reviewers:
mp+207912, lazypower

Visibility:
Public.

Description

SSL Support for RabbitMQ Adds a few additional configuration options for SSL. 'ssl' is the primary one, it can be 'off', 'on', or 'only'. If its off, no changes. If its 'on' then ssl support is enabled and ssl_ca cert is sent to clients along the relation. If its only, then all clients must connect using ssl. The server cert/key and ca cert can be provided via config. If they are not, the service will act as its own ca and provide the ssl_ca cert to its related clients. https://code.launchpad.net/~hazmat/charms/precise/rabbitmq-server/ssl-everywhere/+merge/207912 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+564 lines, -106 lines)			Patch
A	Makefile	View	1 chunk	+15 lines, -0 lines	0 comments	Download
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charm-helpers.yaml	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	config.yaml	View	2 chunks	+22 lines, -4 lines	0 comments	Download
M	hooks/lib/utils.py	View	1 chunk	+8 lines, -11 lines	0 comments	Download
M	hooks/rabbit_utils.py	View	1 chunk	+30 lines, -15 lines	0 comments	Download
M	hooks/rabbitmq_server_relations.py	View	6 chunks	+82 lines, -26 lines	0 comments	Download
M	lib/charmhelpers/contrib/openstack/context.py	View	12 chunks	+108 lines, -41 lines	0 comments	Download
M	lib/charmhelpers/contrib/openstack/utils.py	View	2 chunks	+9 lines, -5 lines	0 comments	Download
A	lib/charmhelpers/contrib/ssl/service.py	View	1 chunk	+266 lines, -0 lines	0 comments	Download
M	lib/charmhelpers/core/hookenv.py	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	revision	View	1 chunk	+1 line, -1 line	0 comments	Download
M	templates/rabbitmq.config	View	1 chunk	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lazypower

10 years, 1 month ago (2014-03-04 15:16:50 UTC) #2

On 2014/02/24 12:11:56, hazmat wrote:
> Please take a look.

+1 LGTM

Expand All Messages | Collapse All Messages