Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(208)

Issue 6813067: code review 6813067: cmd/gc: fix incomplete export data when inlining with l... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by remyoudompheng
Modified:
9 years, 2 months ago
Reviewers:
CC:
golang-dev, rsc, lvd
Visibility:
Public.

Description

cmd/gc: fix incomplete export data when inlining with local variables. When local declarations needed unexported types, these could be missing in the export data. Fixes build with -gcflags -lll, except for exp/gotype.

Patch Set 1 #

Patch Set 2 : diff -r 93dc7f0e302b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 93dc7f0e302b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r b832655cc1e8 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -0 lines) Patch
M src/cmd/gc/export.c View 1 1 chunk +11 lines, -0 lines 0 comments Download
A test/fixedbugs/bug467.go View 1 1 chunk +10 lines, -0 lines 0 comments Download
A test/fixedbugs/bug467.dir/p1.go View 1 1 chunk +5 lines, -0 lines 0 comments Download
A test/fixedbugs/bug467.dir/p2.go View 1 1 chunk +5 lines, -0 lines 0 comments Download
A test/fixedbugs/bug467.dir/p3.go View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3
remyoudompheng
Hello golang-dev@googlegroups.com, rsc@golang.org, lvd@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 2 months ago (2012-10-31 21:53:28 UTC) #1
rsc
LGTM
9 years, 2 months ago (2012-11-01 17:17:14 UTC) #2
remyoudompheng
9 years, 2 months ago (2012-11-01 18:06:58 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=d9a624c22a62 ***

cmd/gc: fix incomplete export data when inlining with local variables.

When local declarations needed unexported types, these could
be missing in the export data.

Fixes build with -gcflags -lll, except for exp/gotype.

R=golang-dev, rsc, lvd
CC=golang-dev
http://codereview.appspot.com/6813067
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b