Charm panel border to 2px (bug #1077006)

Charm panel border to 2px (bug #1077006)

Charm panel's left border should match the UX design and be 2px wide with an inset shadow look.

https://code.launchpad.net/~makyo/juju-gui/charm-panel-border/+merge/133963

(do not edit description out of merge proposal)

[matthew.scott, 2012-11-12 17:39:39]

Please take a look.

[frankban, 2012-11-13 10:24:26]

Thanks Matthew, the inset border looks good, tests pass.
+1 on landing this branch after fixing box shadows: see below.

https://codereview.appspot.com/6812107/diff/1/lib/views/stylesheet.less
File lib/views/stylesheet.less (right):

https://codereview.appspot.com/6812107/diff/1/lib/views/stylesheet.less#newco...
lib/views/stylesheet.less:126: -moz-box-shadow: inset 1px 0 0 lightgray;
Here you can use the .create-box-shadow mixin. You can find it at the beginning
of the file. It lets you create box shadows using a single rule and without
repetitions.

https://codereview.appspot.com/6812107/diff/1/lib/views/stylesheet.less#newco...
lib/views/stylesheet.less:801: -webkit-box-shadow: inset 1px 0 0 lightgray;
Same as above.

https://codereview.appspot.com/6812107/diff/1/lib/views/stylesheet.less#newco...
lib/views/stylesheet.less:846: width: @charm-panel-width -
@charm-panel-padding-left - 1px;
Really nice.

[bac, 2012-11-13 13:27:55]

Looks great Matt.

https://codereview.appspot.com/6812107/diff/1/lib/views/stylesheet.less
File lib/views/stylesheet.less (right):

https://codereview.appspot.com/6812107/diff/1/lib/views/stylesheet.less#newco...
lib/views/stylesheet.less:846: width: @charm-panel-width -
@charm-panel-padding-left - 1px;
On 2012/11/13 10:24:27, francesco.banconi wrote:
> Really nice.

LESS is great, isn't it?

[matthew.scott, 2012-11-13 15:23:00]

Awesome, thanks!

https://codereview.appspot.com/6812107/diff/1/lib/views/stylesheet.less
File lib/views/stylesheet.less (right):

https://codereview.appspot.com/6812107/diff/1/lib/views/stylesheet.less#newco...
lib/views/stylesheet.less:126: -moz-box-shadow: inset 1px 0 0 lightgray;
On 2012/11/13 10:24:27, francesco.banconi wrote:
> Here you can use the .create-box-shadow mixin. You can find it at the
beginning
> of the file. It lets you create box shadows using a single rule and without
> repetitions.

Done.

https://codereview.appspot.com/6812107/diff/1/lib/views/stylesheet.less#newco...
lib/views/stylesheet.less:801: -webkit-box-shadow: inset 1px 0 0 lightgray;
On 2012/11/13 10:24:27, francesco.banconi wrote:
> Same as above.

Done.

[matthew.scott, 2012-11-13 15:27:23]

*** Submitted:

Charm panel border to 2px (bug #1077006)

Charm panel's left border should match the UX design and be 2px wide with an
inset shadow look.

R=francesco.banconi, bac
CC=
https://codereview.appspot.com/6812107