Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(248)

Issue 6812107: Charm panel border to 2px (bug #1077006)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by matthew.scott
Modified:
12 years, 4 months ago
Reviewers:
mp+133963
Visibility:
Public.

Description

Charm panel border to 2px (bug #1077006) Charm panel's left border should match the UX design and be 2px wide with an inset shadow look. https://code.launchpad.net/~makyo/juju-gui/charm-panel-border/+merge/133963 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 6

Patch Set 2 : Charm panel border to 2px (bug #1077006) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/views/stylesheet.less View 1 7 chunks +16 lines, -4 lines 0 comments Download

Messages

Total messages: 5
matthew.scott
Please take a look.
12 years, 4 months ago (2012-11-12 17:39:39 UTC) #1
frankban
Thanks Matthew, the inset border looks good, tests pass. +1 on landing this branch after ...
12 years, 4 months ago (2012-11-13 10:24:26 UTC) #2
bac
Looks great Matt. https://codereview.appspot.com/6812107/diff/1/lib/views/stylesheet.less File lib/views/stylesheet.less (right): https://codereview.appspot.com/6812107/diff/1/lib/views/stylesheet.less#newcode846 lib/views/stylesheet.less:846: width: @charm-panel-width - @charm-panel-padding-left - 1px; ...
12 years, 4 months ago (2012-11-13 13:27:55 UTC) #3
matthew.scott
Awesome, thanks! https://codereview.appspot.com/6812107/diff/1/lib/views/stylesheet.less File lib/views/stylesheet.less (right): https://codereview.appspot.com/6812107/diff/1/lib/views/stylesheet.less#newcode126 lib/views/stylesheet.less:126: -moz-box-shadow: inset 1px 0 0 lightgray; On ...
12 years, 4 months ago (2012-11-13 15:23:00 UTC) #4
matthew.scott
12 years, 4 months ago (2012-11-13 15:27:23 UTC) #5
*** Submitted:

Charm panel border to 2px (bug #1077006)

Charm panel's left border should match the UX design and be 2px wide with an
inset shadow look.

R=francesco.banconi, bac
CC=
https://codereview.appspot.com/6812107
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b