Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(26)

Issue 6812054: remove redundant ant.jar in "tools/myvn eclipse" (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by felix8a
Modified:
13 years, 5 months ago
Reviewers:
kpreid2
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

"myvn eclipse" constructs a .classpath file for eclipse, and currently emits ant.jar twice, which used to be ok, but Eclipse Juno complains about it and refuses to build caja. this removes the redundant ant.jar

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove redundant ant.jar in "tools/myvn eclipse" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M tools/myvn View 1 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5
felix8a
13 years, 5 months ago (2012-10-30 20:27:46 UTC) #1
kpreid2
https://codereview.appspot.com/6812054/diff/1/tools/myvn File tools/myvn (right): https://codereview.appspot.com/6812054/diff/1/tools/myvn#newcode143 tools/myvn:143: echo 'ANT_HOME (eg. export ANT_HOME=/usr/share/ant)' I think this check ...
13 years, 5 months ago (2012-10-30 20:37:51 UTC) #2
felix8a
new snapshot https://codereview.appspot.com/6812054/diff/1/tools/myvn File tools/myvn (right): https://codereview.appspot.com/6812054/diff/1/tools/myvn#newcode143 tools/myvn:143: echo 'ANT_HOME (eg. export ANT_HOME=/usr/share/ant)' ok, deleted
13 years, 5 months ago (2012-10-30 20:40:15 UTC) #3
kpreid2
LGTM
13 years, 5 months ago (2012-10-30 20:43:24 UTC) #4
felix8a
13 years, 5 months ago (2012-10-30 22:53:15 UTC) #5
@r5124
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b