Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)

Issue 6811080: code review 6811080: archive/zip: Fix bounds check panic for ZIP files with ...

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 11 months ago by davemc
Modified:
8 years, 11 months ago
Reviewers:
adg
CC:
adg, dfc, gobot, golang-dev
Visibility:
Public.

Description

archive/zip: Fix bounds check panic for ZIP files with a truncated extra header.

Patch Set 1 #

Patch Set 2 : diff -r c33545ae0ec0 https://code.google.com/p/go #

Patch Set 3 : diff -r ad0d92901061 https://code.google.com/p/go #

Total comments: 4

Patch Set 4 : diff -r ad0d92901061 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -19 lines) Patch
M src/pkg/archive/zip/reader.go View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/pkg/archive/zip/zip_test.go View 1 2 3 2 chunks +31 lines, -18 lines 0 comments Download

Messages

Total messages: 8
davemc
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
8 years, 11 months ago (2012-11-07 02:35:51 UTC) #1
gobot
R=adg (assigned by dsymonds)
8 years, 11 months ago (2012-11-07 03:20:02 UTC) #2
dfc
On 2012/11/07 03:20:02, gobot wrote: > R=adg (assigned by dsymonds) Very nice, thank you for ...
8 years, 11 months ago (2012-11-07 03:52:13 UTC) #3
adg
https://codereview.appspot.com/6811080/diff/3003/src/pkg/archive/zip/zip_test.go File src/pkg/archive/zip/zip_test.go (right): https://codereview.appspot.com/6811080/diff/3003/src/pkg/archive/zip/zip_test.go#newcode193 src/pkg/archive/zip/zip_test.go:193: if _, err = NewReader(bytes.NewReader(b), int64(len(b))); err == nil ...
8 years, 11 months ago (2012-11-07 09:30:26 UTC) #4
davemc
Hello adg@golang.org, dave@cheney.net (cc: gobot@golang.org, golang-dev@googlegroups.com), Please take another look.
8 years, 11 months ago (2012-11-08 00:20:24 UTC) #5
davemc
https://codereview.appspot.com/6811080/diff/3003/src/pkg/archive/zip/zip_test.go File src/pkg/archive/zip/zip_test.go (right): https://codereview.appspot.com/6811080/diff/3003/src/pkg/archive/zip/zip_test.go#newcode193 src/pkg/archive/zip/zip_test.go:193: if _, err = NewReader(bytes.NewReader(b), int64(len(b))); err == nil ...
8 years, 11 months ago (2012-11-08 00:21:00 UTC) #6
adg
LGTM
8 years, 11 months ago (2012-11-08 08:53:32 UTC) #7
adg
8 years, 11 months ago (2012-11-12 11:21:04 UTC) #8
*** Submitted as http://code.google.com/p/go/source/detail?r=f5c69f87ef34 ***

archive/zip: Fix bounds check panic for ZIP files with a truncated extra header.

R=adg, dave
CC=gobot, golang-dev
http://codereview.appspot.com/6811080

Committer: Andrew Gerrand <adg@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b