Automatic sprite image generation

Automatic sprite image generation

The Makefile will automatically generate the sprite png and css
files during the "make server" call for all the images under the 
"app/assets/images" folder.

https://code.launchpad.net/~tveronezi/juju-gui/spritegen/+merge/132077

(do not edit description out of merge proposal)

[thiago, 2012-10-30 11:44:37]

Please take a look.

[thiago, 2012-10-30 11:48:47]

https://codereview.appspot.com/6811050/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/6811050/diff/1/Makefile#newcode15
Makefile:15: SPRITEGEN-VERSION=1.0
Please ignore this line. Its part of a previous solution I had. It is removed.

[gary.poster, 2012-10-30 15:32:44]

Cool, thank you Thiago. We had a few other related comments on our face to face
discussion.  In particular, sprite.css and sprite.png ought to also depend on
grunt and spritesheet.

Gary

https://codereview.appspot.com/6811050/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/6811050/diff/1/Makefile#newcode11
Makefile:11: node_modules/grunt node_modules/node-spritesheet
SPRITE_IMAGES=$(shell bzr ls -k file app/assets/images)

https://codereview.appspot.com/6811050/diff/1/Makefile#newcode52
Makefile:52: 
app/assets/sprite/sprite.css app/assets/sprite/sprite.png: $(SPRITE_IMAGES)
        rm -Rf bin/sprite/
        rm -Rf app/assets/sprite/
        @node_modules/grunt/bin/grunt spritegen
        mv bin/sprite app/assets/sprite/

spritegen: app/assets/sprite/sprite.css app/assets/sprite/sprite.png

https://codereview.appspot.com/6811050/diff/1/Makefile#newcode87
Makefile:87: appcache appcache-touch appcache-force
... \
spritegen yuidoc-lint

https://codereview.appspot.com/6811050/diff/1/app/index.html
File app/index.html (right):

https://codereview.appspot.com/6811050/diff/1/app/index.html#newcode30
app/index.html:30: <img alt="Juju GUI"
As we discussed, we have precedence in the codebase with <i> rather than <img>,
because of bootstrap.css

[thiago, 2012-10-31 08:41:37]

Please take a look.

https://codereview.appspot.com/6811050/diff/1/Makefile
File Makefile (right):

https://codereview.appspot.com/6811050/diff/1/Makefile#newcode11
Makefile:11: node_modules/grunt node_modules/node-spritesheet
On 2012/10/30 15:32:44, gary.poster wrote:
> SPRITE_IMAGES=$(shell bzr ls -k file app/assets/images)

Done.

https://codereview.appspot.com/6811050/diff/1/Makefile#newcode52
Makefile:52: 
On 2012/10/30 15:32:44, gary.poster wrote:
> app/assets/sprite/sprite.css app/assets/sprite/sprite.png: $(SPRITE_IMAGES)
>         rm -Rf bin/sprite/
>         rm -Rf app/assets/sprite/
>         @node_modules/grunt/bin/grunt spritegen
>         mv bin/sprite app/assets/sprite/
> 
> spritegen: app/assets/sprite/sprite.css app/assets/sprite/sprite.png

Done.

https://codereview.appspot.com/6811050/diff/1/Makefile#newcode87
Makefile:87: appcache appcache-touch appcache-force
On 2012/10/30 15:32:44, gary.poster wrote:
> ... \
> spritegen yuidoc-lint

Done.

[thiago, 2012-10-31 08:46:38]

*** Submitted:

Automatic sprite image generation

The Makefile will automatically generate the sprite png and css
files during the "make server" call for all the images under the 
"app/assets/images" folder.

R=gary.poster
CC=
https://codereview.appspot.com/6811050