Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(46)

Issue 6810096: Rewrite end tags to match start tags in html-sanitizer. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by kpreid2
Modified:
13 years, 6 months ago
Reviewers:
metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

When the tagPolicy provided to html-sanitizer modifes the tagName, rewrite matching end tags as well as start tags. Add tests for the tagPolicy-using interface. @r5170

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rewrite end tags to match start tags in html-sanitizer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -17 lines) Patch
M src/com/google/caja/plugin/html-sanitizer.js View 1 6 chunks +33 lines, -17 lines 0 comments Download
M tests/com/google/caja/plugin/html-sanitizer-test.js View 1 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 5
kpreid2
13 years, 7 months ago (2012-11-07 19:30:31 UTC) #1
metaweta
https://codereview.appspot.com/6810096/diff/1/tests/com/google/caja/plugin/html-sanitizer-test.js File tests/com/google/caja/plugin/html-sanitizer-test.js (right): https://codereview.appspot.com/6810096/diff/1/tests/com/google/caja/plugin/html-sanitizer-test.js#newcode350 tests/com/google/caja/plugin/html-sanitizer-test.js:350: checkT('<p>a<xpx r="1">b</xpx>c</p>', Are you closing optional tags before doing ...
13 years, 7 months ago (2012-11-07 21:20:23 UTC) #2
kpreid2
When the tagPolicy provided to html-sanitizer modifes the tagName, rewrite matching end tags as well ...
13 years, 6 months ago (2012-11-29 22:37:33 UTC) #3
kpreid2
https://codereview.appspot.com/6810096/diff/1/tests/com/google/caja/plugin/html-sanitizer-test.js File tests/com/google/caja/plugin/html-sanitizer-test.js (right): https://codereview.appspot.com/6810096/diff/1/tests/com/google/caja/plugin/html-sanitizer-test.js#newcode350 tests/com/google/caja/plugin/html-sanitizer-test.js:350: checkT('<p>a<xpx r="1">b</xpx>c</p>', On 2012/11/07 21:20:23, metaweta wrote: > Are ...
13 years, 6 months ago (2012-11-29 22:53:32 UTC) #4
metaweta
13 years, 6 months ago (2012-11-30 02:06:12 UTC) #5
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b