Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(498)

Issue 6810065: all: gofmt (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by dave
Modified:
11 years, 6 months ago
Reviewers:
mp+132555
Visibility:
Public.

Description

all: gofmt rev 57768598a495 of go fmt now trims trailing whitespace. This has no impact on people using 1.0.x or go tip prior to 57768598a495. https://code.launchpad.net/~dave-cheney/juju-core/043-gofmt-whitespace/+merge/132555 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : all: gofmt #

Patch Set 3 : all: gofmt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -81 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M charm/config.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/filevar.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/filevar_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/addunit.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/get.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/removeunit.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/scp.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/juju/set.go View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cmd/juju/status.go View 2 chunks +2 lines, -2 lines 0 comments Download
M cmd/juju/status_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/jujud/agent_test.go View 1 chunk +1 line, -1 line 0 comments Download
M cmd/jujud/machine_test.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cmd/jujud/unit_test.go View 1 1 chunk +5 lines, -5 lines 0 comments Download
M cmd/output_test.go View 1 chunk +2 lines, -2 lines 0 comments Download
M environs/cloudinit/cloudinit.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/config.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/config/config.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/dummy/environs.go View 2 chunks +4 lines, -4 lines 0 comments Download
M environs/ec2/ec2.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/interface.go View 2 chunks +3 lines, -3 lines 0 comments Download
M environs/tools.go View 1 chunk +1 line, -1 line 0 comments Download
M state/conn_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/machine.go View 1 chunk +1 line, -1 line 0 comments Download
M state/machine_test.go View 1 2 1 chunk +1 line, -1 line 0 comments Download
M state/open.go View 1 chunk +1 line, -1 line 0 comments Download
M state/presence/presence.go View 1 chunk +1 line, -1 line 0 comments Download
M state/relation_internal_test.go View 1 1 chunk +6 lines, -6 lines 0 comments Download
M state/service.go View 1 1 chunk +1 line, -1 line 0 comments Download
M state/service_test.go View 1 1 chunk +3 lines, -3 lines 0 comments Download
M state/ssh.go View 1 chunk +1 line, -1 line 0 comments Download
M state/state.go View 1 chunk +1 line, -1 line 0 comments Download
M state/state_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/unit.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M state/watcher.go View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M trivial/attempt.go View 1 chunk +1 line, -1 line 0 comments Download
M version/version.go View 2 chunks +2 lines, -2 lines 0 comments Download
M worker/firewaller/firewaller.go View 3 chunks +3 lines, -3 lines 0 comments Download
M worker/firewaller/firewaller_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M worker/provisioner/export_test.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/provisioner/provisioner.go View 3 chunks +4 lines, -4 lines 0 comments Download
M worker/provisioner/provisioner_test.go View 6 chunks +8 lines, -8 lines 0 comments Download
M worker/uniter/jujuc/util_test.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M worker/uniter/relation/hookqueue.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
dave_cheney.net
Please take a look.
11 years, 6 months ago (2012-11-01 14:10:19 UTC) #1
jameinel
LGTM
11 years, 6 months ago (2012-11-01 14:43:37 UTC) #2
aram
Could you please run gofmt -s?
11 years, 6 months ago (2012-11-01 15:20:41 UTC) #3
dave_cheney.net
Please take a look.
11 years, 6 months ago (2012-11-01 15:49:09 UTC) #4
aram
LGTM
11 years, 6 months ago (2012-11-01 16:30:58 UTC) #5
dave_cheney.net
11 years, 6 months ago (2012-11-02 12:25:46 UTC) #6
*** Submitted:

all: gofmt

rev 57768598a495 of go fmt now trims trailing whitespace. This has no impact on
people using 1.0.x or go tip prior to 57768598a495.

R=john.meinel, aram
CC=
https://codereview.appspot.com/6810065
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b