Issue 68080046: code review 68080046: crypto/sha1: restore accidental removal of arm build tag

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 68080046: code review 68080046: crypto/sha1: restore accidental removal of arm build tag (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by bradfitz

Modified:
11 years, 4 months ago

Reviewers:
dave

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

crypto/sha1: restore accidental removal of arm build tag Regression from https://codereview.appspot.com/68490043/diff/60001/src/pkg/crypto/sha1/sha1block_decl.go Fixes arm build.

Patch Set 1 #

Patch Set 2 : diff -r 838ade034dc6 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 838ade034dc6 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 838ade034dc6 https://go.googlecode.com/hg/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/crypto/sha1/sha1block_decl.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 4 months ago (2014-02-25 18:54:47 UTC) #1

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=ad9c5ca63757 *** crypto/sha1: restore accidental removal of arm build tag Regression from ...

11 years, 4 months ago (2014-02-25 18:55:31 UTC) #2

dave_cheney.net

11 years, 4 months ago (2014-02-25 20:02:37 UTC) #3

LGTM. Thanks


On Wed, Feb 26, 2014 at 5:55 AM, <bradfitz@golang.org> wrote:

> *** Submitted as
> https://code.google.com/p/go/source/detail?r=ad9c5ca63757 ***
>
>
> crypto/sha1: restore accidental removal of arm build tag
>
> Regression from
> https://codereview.appspot.com/68490043/diff/60001/src/
> pkg/crypto/sha1/sha1block_decl.go
>
> Fixes arm build.
>
> TBR=rsc
> R=rsc
> CC=golang-codereviews
> https://codereview.appspot.com/68080046
>
>
> https://codereview.appspot.com/68080046/
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

Expand All Messages | Collapse All Messages