code review 68050043: sync: use RunParallel in benchmarks

sync: use RunParallel in benchmarks

[dvyukov, 2014-02-24 09:33:18]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://dvyukov%40google.com@code.google.com/p/go/

[bradfitz, 2014-02-24 16:44:09]

LGTM

https://codereview.appspot.com/68050043/diff/10002/src/pkg/sync/mutex_test.go
File src/pkg/sync/mutex_test.go (right):

https://codereview.appspot.com/68050043/diff/10002/src/pkg/sync/mutex_test.go...
src/pkg/sync/mutex_test.go:89: type PaddedMutex struct {
I would keep this out a level, like it was before.

https://codereview.appspot.com/68050043/diff/10002/src/pkg/sync/once_test.go
File src/pkg/sync/once_test.go (right):

https://codereview.appspot.com/68050043/diff/10002/src/pkg/sync/once_test.go#...
src/pkg/sync/once_test.go:67: once.Do(f)
cute, you can actually see what's being tested now!

https://codereview.appspot.com/68050043/diff/10002/src/pkg/sync/runtime_sema_...
File src/pkg/sync/runtime_sema_test.go (right):

https://codereview.appspot.com/68050043/diff/10002/src/pkg/sync/runtime_sema_...
src/pkg/sync/runtime_sema_test.go:15: type PaddedSem struct {
move this out one level?

https://codereview.appspot.com/68050043/diff/10002/src/pkg/sync/rwmutex_test.go
File src/pkg/sync/rwmutex_test.go (right):

https://codereview.appspot.com/68050043/diff/10002/src/pkg/sync/rwmutex_test....
src/pkg/sync/rwmutex_test.go:160: type PaddedRWMutex struct {
out one?

https://codereview.appspot.com/68050043/diff/10002/src/pkg/sync/waitgroup_tes...
File src/pkg/sync/waitgroup_test.go (right):

https://codereview.appspot.com/68050043/diff/10002/src/pkg/sync/waitgroup_tes...
src/pkg/sync/waitgroup_test.go:64: type PaddedWaitGroup struct {
out one level?

[dvyukov, 2014-02-25 10:38:47]

https://codereview.appspot.com/68050043/diff/10002/src/pkg/sync/mutex_test.go
File src/pkg/sync/mutex_test.go (right):

https://codereview.appspot.com/68050043/diff/10002/src/pkg/sync/mutex_test.go...
src/pkg/sync/mutex_test.go:89: type PaddedMutex struct {
On 2014/02/24 16:44:09, bradfitz wrote:
> I would keep this out a level, like it was before.

Done.

https://codereview.appspot.com/68050043/diff/10002/src/pkg/sync/runtime_sema_...
File src/pkg/sync/runtime_sema_test.go (right):

https://codereview.appspot.com/68050043/diff/10002/src/pkg/sync/runtime_sema_...
src/pkg/sync/runtime_sema_test.go:15: type PaddedSem struct {
On 2014/02/24 16:44:09, bradfitz wrote:
> move this out one level?

Done.

https://codereview.appspot.com/68050043/diff/10002/src/pkg/sync/rwmutex_test.go
File src/pkg/sync/rwmutex_test.go (right):

https://codereview.appspot.com/68050043/diff/10002/src/pkg/sync/rwmutex_test....
src/pkg/sync/rwmutex_test.go:160: type PaddedRWMutex struct {
On 2014/02/24 16:44:09, bradfitz wrote:
> out one?

Done.

https://codereview.appspot.com/68050043/diff/10002/src/pkg/sync/waitgroup_tes...
File src/pkg/sync/waitgroup_test.go (right):

https://codereview.appspot.com/68050043/diff/10002/src/pkg/sync/waitgroup_tes...
src/pkg/sync/waitgroup_test.go:64: type PaddedWaitGroup struct {
On 2014/02/24 16:44:09, bradfitz wrote:
> out one level?

Done.

[dvyukov, 2014-02-25 10:39:16]

*** Submitted as https://code.google.com/p/go/source/detail?r=6e163a22bea3 ***

sync: use RunParallel in benchmarks

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/68050043