Issue 68040044: code review 68040044: net/rpc: use RunParallel in benchmarks

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 68040044: code review 68040044: net/rpc: use RunParallel in benchmarks (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by dvyukov

Modified:
11 years, 4 months ago

Reviewers:
gobot, bradfitz

CC:
golang-codereviews, bradfitz

Visibility:
Public.

Patch Set 2 : diff -r 3cf533be5e36 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 3cf533be5e36 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 5ae089f46a43 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -23 lines)			Patch
	M	src/pkg/net/rpc/server_test.go	View	1	3 chunks	+13 lines, -23 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years, 4 months ago (2014-02-24 10:02:06 UTC) #1

dvyukov

*** Submitted as https://code.google.com/p/go/source/detail?r=efa3ac9812cb *** net/rpc: use RunParallel in benchmarks LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://codereview.appspot.com/68040044

11 years, 4 months ago (2014-02-24 16:24:18 UTC) #3

Message was sent while issue was closed.

This CL appears to have broken the windows-amd64 builder.

Expand All Messages | Collapse All Messages