Issue 67990043: code review 67990043: runtime: fix potential memory corruption

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 67990043: code review 67990043: runtime: fix potential memory corruption (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by dvyukov

Modified:
10 years, 2 months ago

Reviewers:
gobot, rsc

CC:
golang-codereviews, khr, rsc

Visibility:
Public.

Description

runtime: fix potential memory corruption Reinforce the guarantee that MSpan_EnsureSwept actually ensures that the span is swept. I have not observed crashes related to this, but I do not see why it can't crash as well.

Patch Set 1 #

Patch Set 2 : diff -r cf5dd8accd5e https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r cf5dd8accd5e https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 8379b111d712 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -3 lines)			Patch
	M	src/pkg/runtime/mgc0.c	View	1	1 chunk	+6 lines, -3 lines	0 comments	Download
	M	src/pkg/runtime/mheap.c	View	1	6 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

10 years, 2 months ago (2014-02-24 08:21:17 UTC) #1

dvyukov

*** Submitted as https://code.google.com/p/go/source/detail?r=de23a6a5048d *** runtime: fix potential memory corruption Reinforce the guarantee that MSpan_EnsureSwept ...

10 years, 2 months ago (2014-02-24 16:53:25 UTC) #3

gobot

10 years, 2 months ago (2014-02-25 02:47:13 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the linux-arm-cheney-panda builder.

Expand All Messages | Collapse All Messages