Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(510)

Issue 67980043: code review 67980043: runtime: fix heap memory corruption (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by dvyukov
Modified:
10 years, 2 months ago
Reviewers:
rsc
CC:
golang-codereviews, minux1, rsc, khr
Visibility:
Public.

Description

runtime: fix heap memory corruption With concurrent sweeping finc if modified by runfinq and queuefinalizer concurrently. Fixes crashes like this one: http://build.golang.org/log/6ad7b59ef2e93e3c9347eabfb4c4bd66df58fd5a Fixes issue 7324. Update issue 7396

Patch Set 1 #

Patch Set 2 : diff -r cf5dd8accd5e https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r cf5dd8accd5e https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r de23a6a5048d https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/pkg/runtime/mgc0.c View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10
dvyukov
Hello golang-codereviews@googlegroups.com (cc: khr@golang.org, rsc@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 2 months ago (2014-02-24 08:01:27 UTC) #1
minux1
Unfortunately, this doesn't fix the crash on DflyBSD during go test -v -short std, it ...
10 years, 2 months ago (2014-02-24 08:12:41 UTC) #2
dvyukov
On Mon, Feb 24, 2014 at 12:12 PM, minux <minux.ma@gmail.com> wrote: > Unfortunately, this doesn't ...
10 years, 2 months ago (2014-02-24 08:19:48 UTC) #3
minux1
On Mon, Feb 24, 2014 at 3:19 AM, Dmitry Vyukov <dvyukov@google.com> wrote: > On Mon, ...
10 years, 2 months ago (2014-02-24 08:52:03 UTC) #4
dvyukov
it seems to be bgsweep goroutine does it always crash in the same goroutine? what ...
10 years, 2 months ago (2014-02-24 08:59:50 UTC) #5
minux1
On Mon, Feb 24, 2014 at 3:59 AM, Dmitry Vyukov <dvyukov@google.com> wrote: > it seems ...
10 years, 2 months ago (2014-02-24 09:13:38 UTC) #6
rsc
LGTM but please fix the "fixes issue / update issue" appropriately to reflect minux's reports ...
10 years, 2 months ago (2014-02-24 15:01:53 UTC) #7
dvyukov
On 2014/02/24 15:01:53, rsc wrote: > LGTM but please fix the "fixes issue / update ...
10 years, 2 months ago (2014-02-24 15:13:12 UTC) #8
rsc
LGTM fine as is.
10 years, 2 months ago (2014-02-24 16:48:40 UTC) #9
dvyukov
10 years, 2 months ago (2014-02-24 16:53:55 UTC) #10
*** Submitted as https://code.google.com/p/go/source/detail?r=1bbfa797b8ed ***

runtime: fix heap memory corruption
With concurrent sweeping finc if modified by runfinq and queuefinalizer
concurrently.
Fixes crashes like this one:
http://build.golang.org/log/6ad7b59ef2e93e3c9347eabfb4c4bd66df58fd5a
Fixes issue 7324.
Update issue 7396

LGTM=rsc
R=golang-codereviews, minux.ma, rsc
CC=golang-codereviews, khr
https://codereview.appspot.com/67980043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b