Issue 67870056: code review 67870056: runtime: print goroutine header on fault

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 67870056: code review 67870056: runtime: print goroutine header on fault (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by dvyukov

Modified:
11 years, 3 months ago

Reviewers:
gobot, rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

runtime: print goroutine header on fault I've just needed the G status on fault to debug runtime bug. For some reason we print everything except header here. Make it more informative and consistent.

Patch Set 1 #

Patch Set 2 : diff -r 32f0dc88f804 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 32f0dc88f804 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 32f0dc88f804 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 8140f2850ec9 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
M	src/pkg/runtime/signal_386.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/runtime/signal_amd64.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/runtime/signal_arm.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

11 years, 3 months ago (2014-03-06 09:40:10 UTC) #1

dvyukov

*** Submitted as https://code.google.com/p/go/source/detail?r=4784aeee8b4a *** runtime: print goroutine header on fault I've just needed the ...

11 years, 3 months ago (2014-03-06 20:04:27 UTC) #3

gobot

11 years, 3 months ago (2014-03-06 20:39:48 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the linux-amd64-race builder.

Expand All Messages | Collapse All Messages