Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(781)

Issue 67870053: code review 67870053: net/http: deflake another alloc test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 3 months ago by bradfitz
Modified:
5 years, 3 months ago
Reviewers:
josharian
CC:
josharian, golang-codereviews
Visibility:
Public.

Description

net/http: deflake another alloc test I have one machine where this 25 test run is flaky and fails ("21 >= 21"), but 50 works everywhere.

Patch Set 1 #

Patch Set 2 : diff -r 771ed4628e95 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 771ed4628e95 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 3982c3b1380b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pkg/net/http/serve_test.go View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
bradfitz
Hello josharian@gmail.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
5 years, 3 months ago (2014-03-04 16:58:19 UTC) #1
josharian
LGTM Sad, though. Pity we just crossed the Go 1.3 feature freeze mark, because I'd ...
5 years, 3 months ago (2014-03-04 17:46:33 UTC) #2
bradfitz
5 years, 3 months ago (2014-03-04 17:59:09 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=363a4ef7e011 ***

net/http: deflake another alloc test

I have one machine where this 25 test run is flaky
and fails ("21 >= 21"), but 50 works everywhere.

LGTM=josharian
R=josharian
CC=golang-codereviews
https://codereview.appspot.com/67870053
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b