Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1040)

Issue 67870045: provider/local: Destroy partial environments

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by axw
Modified:
10 years, 2 months ago
Reviewers:
mp+208748, thumper
Visibility:
Public.

Description

provider/local: Destroy partial environments Destroy is improved so that it does not assume a complete/working environment. It will now handle the scenario where bootstrap failed to gain sudo rights. It will also remove the ~/.juju/local directory as a final step. Additionally, fixed Destroy to stop passing all of os.Args through to the sudo call, and construct the call explicitly. Fixes lp:1273295 Fixes lp:1281863 https://code.launchpad.net/~axwalk/juju-core/lp1273295-local-destroy-broken-env/+merge/208748 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : provider/local: Destroy partial environments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -33 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M provider/local/environ.go View 1 3 chunks +46 lines, -19 lines 1 comment Download
M provider/local/environ_test.go View 5 chunks +64 lines, -14 lines 0 comments Download

Messages

Total messages: 4
axw
Please take a look.
10 years, 2 months ago (2014-02-28 09:02:33 UTC) #1
axw
Please take a look.
10 years, 2 months ago (2014-02-28 09:17:40 UTC) #2
axw
https://codereview.appspot.com/67870045/diff/20001/provider/local/environ.go File provider/local/environ.go (right): https://codereview.appspot.com/67870045/diff/20001/provider/local/environ.go#newcode168 provider/local/environ.go:168: fmt.Sprintf("chown syslog:adm %s", mcfg.LogDir), Reviewers: this was slipped in ...
10 years, 2 months ago (2014-03-04 02:49:05 UTC) #3
thumper
10 years, 2 months ago (2014-03-04 03:00:03 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b