code review 6785053: cmd/api: new goapi_test for http://codereview.appspot.c...

cmd/api: new goapi_test for http://codereview.appspot.com/6742050

[visualfc, 2012-11-16 01:56:17]

Hello golang-dev@googlegroups.com (cc: bradfitz@golang.org),

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2012-11-18 04:00:09]

You should put these in the same CL.


On Thu, Nov 15, 2012 at 5:56 PM, <VisualFC@gmail.com> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev@googlegroups.com (cc: bradfitz@golang.org),
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> cmd/api: new goapi_test for
http://codereview.appspot.com/**6742050<http://codereview.appspot.com/6742050>
>
> Please review this at
http://codereview.appspot.com/**6785053/<http://codereview.appspot.com/6785053/>
>
> Affected files:
>   M src/cmd/api/goapi_test.go
>
>
> Index: src/cmd/api/goapi_test.go
> ==============================**==============================**=======
> --- a/src/cmd/api/goapi_test.go
> +++ b/src/cmd/api/goapi_test.go
> @@ -8,6 +8,7 @@
>         "bytes"
>         "flag"
>         "fmt"
> +       "go/build"
>         "io/ioutil"
>         "os"
>         "path/filepath"
> @@ -22,6 +23,7 @@
>
>  func TestGolden(t *testing.T) {
>         td, err := os.Open("testdata/src/pkg")
> +
>         if err != nil {
>                 t.Fatal(err)
>         }
> @@ -29,15 +31,19 @@
>         if err != nil {
>                 t.Fatal(err)
>         }
> +       context := &build.Default
> +       context.GOROOT = "testdata"
> +
>         for _, fi := range fis {
>                 if !fi.IsDir() {
>                         continue
>                 }
>                 w := NewWalker()
>                 w.wantedPkg[fi.Name()] = true
> +               w.context = context
>
> -               w.root = "testdata/src/pkg"
>                 goldenFile := filepath.Join("testdata", "src", "pkg",
> fi.Name(), "golden.txt")
> +
>                 w.WalkPackage(fi.Name())
>
>                 if *updateGolden {
> @@ -46,7 +52,7 @@
>                         if err != nil {
>                                 t.Fatal(err)
>                         }
> -                       for _, feat := range w.Features() {
> +                       for _, feat := range w.Features("") {
>                                 fmt.Fprintf(f, "%s\n", feat)
>                         }
>                         f.Close()
> @@ -58,18 +64,23 @@
>                 }
>                 wanted := strings.Split(string(bs), "\n")
>                 sort.Strings(wanted)
> +
> +               features := make(map[string]bool)
> +               for _, p := range w.Features("") {
> +                       features[p] = true
> +               }
> +
>                 for _, feature := range wanted {
>                         if feature == "" {
>                                 continue
>                         }
> -                       _, ok := w.features[feature]
> +                       _, ok := features[feature]
>                         if !ok {
>                                 t.Errorf("package %s: missing feature %q",
> fi.Name(), feature)
>                         }
> -                       delete(w.features, feature)
> +                       delete(features, feature)
>                 }
> -
> -               for _, feature := range w.Features() {
> +               for _, feature := range features {
>                         t.Errorf("package %s: extra feature not in golden
> file: %q", fi.Name(), feature)
>                 }
>         }
>
>
>

[bradfitz, 2013-06-05 20:57:03]

R=close

This was merged into another CL that was subsequently rejected as too invasive. 
This should all be forked out-of-tree.