Issue 6782139: code review 6782139: net/http: don't send chunked encoding on 204 responses

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6782139: code review 6782139: net/http: don't send chunked encoding on 204 responses (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by bradfitz

Modified:
11 years, 4 months ago

Reviewers:

CC:
golang-dev

Visibility:
Public.

Description

net/http: don't send chunked encoding on 204 responses RFC 2616: "The 204 response MUST NOT include a message-body, and thus is always terminated by the first empty line after the header fields." Previously we'd trigger chunked encoding by default on responses, and then when finishing the request we'd write the chunk trailers, which counted as a message-body. Fixes issue 4454

Patch Set 1 #

Patch Set 2 : diff -r 529f67226610 https://code.google.com/p/go #

Patch Set 3 : diff -r 529f67226610 https://code.google.com/p/go #

Patch Set 4 : diff -r 751e8610bd5d https://code.google.com/p/go #

Patch Set 5 : diff -r 751e8610bd5d https://go.googlecode.com/hg/ #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -0 lines)			Patch
	M	src/pkg/net/http/server.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/pkg/net/http/transport_test.go	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 4 months ago (2012-11-30 00:30:44 UTC) #1

bradfitz

11 years, 4 months ago (2012-11-30 02:01:10 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=86eed47f9b5c ***

net/http: don't send chunked encoding on 204 responses

RFC 2616: "The 204 response MUST NOT include a message-body,
and thus is always terminated by the first empty line after
the header fields."

Previously we'd trigger chunked encoding by default on
responses, and then when finishing the request we'd write the
chunk trailers, which counted as a message-body.

Fixes issue 4454

R=golang-dev
CC=golang-dev
https://codereview.appspot.com/6782139

Expand All Messages | Collapse All Messages