Issue 6782094: environs/config: error for cert not found

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6782094: environs/config: error for cert not found

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by rog

Modified:
11 years, 5 months ago

Reviewers:
mp+135206, niemeyer

Visibility:
Public.

Description

environs/config: error for cert not found We change config.New so that it returns a special error when the default CA certificate is not found. This will enable us to act on that error and generate a certificate file when necessary. https://code.launchpad.net/~rogpeppe/juju-core/156-config-error-return/+merge/135206 Requires: https://code.launchpad.net/~rogpeppe/juju-core/149-state-info-rootcert/+merge/134642 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/config: error for cert not found #

Total comments: 2

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -24 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/config/config.go	View	5 chunks	+22 lines, -12 lines	2 comments	Download
M	environs/config/config_test.go	View	4 chunks	+79 lines, -12 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

niemeyer

11 years, 5 months ago (2012-11-20 22:32:53 UTC) #2

https://codereview.appspot.com/6782094/diff/2001/environs/config/config.go
File environs/config/config.go (right):

https://codereview.appspot.com/6782094/diff/2001/environs/config/config.go#ne...
environs/config/config.go:34: var ErrDefaultCACertNotFound = errors.New("default
CA certificate not found")
s/ErrDefaultCACertNotFound/ErrNoCert/? (!)

Also, I believe this can be returned at all times, whenever we have no
certificate. We can trivially take decisions based on the availability of keys
in the map in the one place we'll care.

https://codereview.appspot.com/6782094/diff/2001/environs/config/config.go#ne...
environs/config/config.go:54: // If no CA  details are specified and no CA
certificate
Double space.

Expand All Messages | Collapse All Messages