Issue 6782076: oauth issue 60: FileCredentialStore: don't allow symbolic link

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6782076: oauth issue 60: FileCredentialStore: don't allow symbolic link (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by yanivi

Modified:
11 years, 5 months ago

Reviewers:
ngmiceli

CC:
rmistry

Base URL:
https://google-oauth-java-client.googlecode.com/hg/

Visibility:
Public.

More Reviews

Description

oauth issue 60: FileCredentialStore: don't allow symbolic link http://code.google.com/p/google-oauth-java-client/issues/detail?id=60 FileCredentialStore: don't allow symbolic link

Patch Set 1 #

Patch Set 2 : Issue 60: FileCredentialStore: don't allow symbolic link #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -5 lines)			Patch
M	google-oauth-client-assembly/readme.html	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	google-oauth-client-java6/pom.xml	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	google-oauth-client-java6/src/main/java/com/google/api/client/extensions/java6/auth/oauth2/FileCredentialStore.java	View	1	3 chunks	+16 lines, -0 lines	0 comments	Download
M	google-oauth-client/src/test/java/com/google/api/client/auth/oauth2/CredentialTest.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pom.xml	View	1	3 chunks	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ngmiceli

11 years, 5 months ago (2012-11-21 15:45:48 UTC) #2

On 2012/11/15 21:20:16, yanivi wrote:

Note dependent on https://codereview.appspot.com/6846062/

LGTM

Expand All Messages | Collapse All Messages