Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2466)

Issue 67820046: code review 67820046: all: DragonFly port. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 2 months ago by minux1
Modified:
10 years, 1 month ago
Reviewers:
rsc
CC:
rsc
Visibility:
Public.

Description

all: DragonFly port. Fix compilation problems, libdraw still doesn't work right yet.

Patch Set 1 #

Patch Set 2 : diff -r bdbf5fc51eec https://code.google.com/p/plan9port #

Patch Set 3 : diff -r bdbf5fc51eec https://code.google.com/p/plan9port #

Patch Set 4 : diff -r bdbf5fc51eec https://code.google.com/p/plan9port #

Patch Set 5 : diff -r bdbf5fc51eec https://code.google.com/p/plan9port #

Patch Set 6 : diff -r bdbf5fc51eec https://code.google.com/p/plan9port #

Patch Set 7 : diff -r bdbf5fc51eec https://code.google.com/p/plan9port #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -12 lines) Patch
M INSTALL View 1 1 chunk +6 lines, -0 lines 0 comments Download
M bin/9c View 1 1 chunk +1 line, -1 line 0 comments Download
M bin/9l View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/9660srv/main.c View 1 2 chunks +1 line, -1 line 0 comments Download
M src/cmd/9term/DragonFly.c View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/cmd/9term/mkfile View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/auxstats/DragonFly.c View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M src/cmd/eqn/lex.c View 1 2 3 4 5 4 chunks +3 lines, -3 lines 0 comments Download
M src/cmd/tpic/input.c View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/cmd/vbackup/mount-DragonFly.c View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/lib9/dirread.c View 1 5 chunks +11 lines, -5 lines 0 comments Download
M src/libip/DragonFly.c View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/libip/mkfile View 1 1 chunk +1 line, -1 line 0 comments Download
M src/libmach/DragonFly.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9
minux1
Hello rsc@golang.org, I'd like you to review this change to https://code.google.com/p/plan9port
10 years, 2 months ago (2014-02-24 08:36:28 UTC) #1
minux1
devdraw crashed very early. Program terminated with signal 11, Segmentation fault. #0 _initdisplaymemimage (m=0x0) at ...
10 years, 2 months ago (2014-02-24 08:37:38 UTC) #2
minux1
Also, do we have any customization of the codereview.py? I got this while trying the ...
10 years, 2 months ago (2014-02-24 08:55:21 UTC) #3
rsc
LGTM please just fix the 2 lines in lex.c that use spaces instead of tabs.
10 years, 2 months ago (2014-02-24 14:45:36 UTC) #4
minux1
*** Submitted as https://code.google.com/p/plan9port/source/detail?r=18c38bf29b0b *** all: DragonFly port. Fix compilation problems, libdraw still doesn't work ...
10 years, 2 months ago (2014-02-28 04:17:50 UTC) #5
minux1
On Mon, Feb 24, 2014 at 3:37 AM, <minux.ma@gmail.com> wrote: > devdraw crashed very early. ...
10 years, 1 month ago (2014-03-01 08:49:26 UTC) #6
rsc
On Sat, Mar 1, 2014 at 3:49 AM, minux <minux.ma@gmail.com> wrote: > > On Mon, ...
10 years, 1 month ago (2014-03-03 16:44:50 UTC) #7
minux1
On Mon, Mar 3, 2014 at 11:44 AM, Russ Cox <rsc@golang.org> wrote: > send me ...
10 years, 1 month ago (2014-03-05 21:57:11 UTC) #8
minux1
10 years, 1 month ago (2014-03-07 04:32:14 UTC) #9
On Wed, Mar 5, 2014 at 4:56 PM, minux <minux.ma@gmail.com> wrote:
>
> On Mon, Mar 3, 2014 at 11:44 AM, Russ Cox <rsc@golang.org> wrote:
>
>> send me a CL.
>>
> I didn't find where is the index.html in the tree, so i will attach the
> diff to you.
> (it's intended for http://swtch.com/plan9port/index.html)
>
please ignore the patch, i've sent the correct CL (CL 72340043) for that
file,
sorry i didn't know why my initial grep didn't find dist/main.html.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b