Issue 67820043: cmd/ld: fix build for ARMv5.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 67820043: cmd/ld: fix build for ARMv5. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by minux1

Modified:
10 years, 1 month ago

Reviewers:
gobot, rsc, dave

CC:
dave_cheney.net, rsc, golang-codereviews

Visibility:
Public.

Description

cmd/ld: fix build for ARMv5. Credit goes to Dave Cheney for debugging the issue.

Patch Set 1 #

Patch Set 2 : diff -r 737d232b573b https://code.google.com/p/go #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/ld/data.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dave_cheney.net

LGTM. Please wait for Ian or Russ Passes on * linux/arm armv5 * linux/arm armv7 ...

10 years, 2 months ago (2014-02-24 05:15:36 UTC) #1

dave_cheney.net

*** Submitted as https://code.google.com/p/go/source/detail?r=c33b9dafa027 *** cmd/ld: fix build for ARMv5. Credit goes to Dave Cheney ...

10 years, 2 months ago (2014-02-24 19:53:42 UTC) #3

dave_cheney.net

10 years, 2 months ago (2014-02-24 20:37:08 UTC) #5

Not really, this is the occasional divmod.exe panic bug.


On Tue, Feb 25, 2014 at 7:27 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the windows-amd64 builder.
>
> https://codereview.appspot.com/67820043/
>

Expand All Messages | Collapse All Messages