Issue 67800044: code review 67800044: syscall: consolidate test cases for Unix-like systems

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 67800044: code review 67800044: syscall: consolidate test cases for Unix-like systems (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 4 months ago by mikio

Modified:
11 years, 4 months ago

Reviewers:
minux1, bradfitz

CC:
iant, bradfitz, golang-codereviews

Visibility:
Public.

Description

syscall: consolidate test cases for Unix-like systems As per request from minux in CL 61520049, this CL consolidates existing test cases for Unix-like systems into one file except Linux-specific credential test.

Patch Set 1 : diff -r 737d232b573b https://code.google.com/p/go #

Total comments: 1

Patch Set 2 : diff -r 5199df0e0f2f https://code.google.com/p/go #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+232 lines, -254 lines)			Patch
R	src/pkg/syscall/passfd_test.go	View	1 chunk	+0 lines, -202 lines	0 comments	Download
R	src/pkg/syscall/rlimit_unix_test.go	View	1 chunk	+0 lines, -51 lines	0 comments	Download
M	src/pkg/syscall/syscall_unix_test.go	View	2 chunks	+232 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

mikio

Hello iant@golang.org, minux.ma@gmail.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 4 months ago (2014-02-24 04:27:47 UTC) #1

mikio

*** Submitted as https://code.google.com/p/go/source/detail?r=cf5dd8accd5e *** syscall: consolidate test cases for Unix-like systems As per request ...

11 years, 4 months ago (2014-02-24 05:41:17 UTC) #3

minux1

https://codereview.appspot.com/67800044/diff/60001/src/pkg/syscall/syscall_unix_test.go File src/pkg/syscall/syscall_unix_test.go (right): https://codereview.appspot.com/67800044/diff/60001/src/pkg/syscall/syscall_unix_test.go#newcode7 src/pkg/syscall/syscall_unix_test.go:7: // This file tests that some basic syscalls are ...

11 years, 4 months ago (2014-02-24 05:45:45 UTC) #4

mikio

11 years, 4 months ago (2014-02-24 05:50:02 UTC) #5

will do in cl 58660044

On Mon, Feb 24, 2014 at 2:45 PM,  <minux.ma@gmail.com> wrote:
>
>
https://codereview.appspot.com/67800044/diff/60001/src/pkg/syscall/syscall_un...
> File src/pkg/syscall/syscall_unix_test.go (right):
>
>
https://codereview.appspot.com/67800044/diff/60001/src/pkg/syscall/syscall_un...
> src/pkg/syscall/syscall_unix_test.go:7: // This file tests that some
> basic syscalls are consistent across
> please update this comment.
>
> https://codereview.appspot.com/67800044/

Expand All Messages | Collapse All Messages